[User Model] Don't show "Missing Google Project number!" error message until remote config loaded.

Author: brismithers

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/config/ConfigModel.kt

@@ -5,6 +5,13 @@ import org.json.JSONArray
 import org.json.JSONObject
 
 class ConfigModel : Model() {
+    /**
+     * Whether this config has been initialized with remote data.
+     */
+    var isInitializedWithRemote: Boolean
+        get() = getBooleanProperty(::isInitializedWithRemote.name) { false }
+        set(value) { setBooleanProperty(::isInitializedWithRemote.name, value) }
+
     /**
      * The current OneSignal application ID provided to the SDK.
      */

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/config/impl/ConfigModelStoreListener.kt

@@ -68,6 +68,8 @@ internal class ConfigModelStoreListener(
                     val config = ConfigModel()
                     config.initializeFromModel(null, _configModelStore.model)
 
+                    config.isInitializedWithRemote = true
+
                     // these are always copied from the backend params
                     config.appId = appId
                     config.notificationChannels = params.notificationChannels

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/internal/registration/impl/PushRegistratorAbstractGoogle.kt

@@ -51,6 +51,10 @@ internal abstract class PushRegistratorAbstractGoogle(
     abstract suspend fun getToken(senderId: String): String
 
     override suspend fun registerForPush(): IPushRegistrator.RegisterResult {
+        if(!_configModelStore.model.isInitializedWithRemote) {
+            return IPushRegistrator.RegisterResult(null, SubscriptionStatus.FIREBASE_FCM_INIT_ERROR)
+        }
+
         if (!_deviceService.hasFCMLibrary) {
             Logging.fatal("The Firebase FCM library is missing! Please make sure to include it in your project.")
             return IPushRegistrator.RegisterResult(null, SubscriptionStatus.MISSING_FIREBASE_FCM_LIBRARY)