Unit test setupContextListeners not completing

- Add unit test: initWithContext_setupContextListenersNotCompleted_doesNotProduceNPE to reproduce the NPE of `outcomeEventsController` in `init()`.

- Shadow the `OneSignal.setupContextListeners()` method to simulate it not completing (thus not initializing the `outcomeEventsController`).

- Add new shadow of OneSignal besides ShadowOneSignal named `ShadowOneSignalWithMockSetupContextListeners` so other unit tests using `ShadowOneSignal` don't have behavior changed

- However, the `languageContext` initialization is needed or else it leads to a subsequent NPE for this property in `registerUserTask()`.

- Change access of `languageContext` in OneSignal.java from private to package-private so it can be accessed in unit tests.

Author: nan-li

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

@@ -370,7 +370,8 @@ static Activity getCurrentActivity() {
    private static String smsId = null;
    private static int subscribableStatus = Integer.MAX_VALUE;
 
-   private static LanguageContext languageContext = null;
+   // changed from private to package-private for unit test access
+   static LanguageContext languageContext = null;
 
    static OSRemoteNotificationReceivedHandler remoteNotificationReceivedHandler;
    static OSNotificationWillShowInForegroundHandler notificationWillShowInForegroundHandler;

OneSignalSDK/unittest/src/test/java/com/onesignal/ShadowOneSignalWithMockSetupContextListeners.java

@@ -0,0 +1,27 @@
+package com.onesignal;
+
+import com.onesignal.language.LanguageContext;
+
+import org.robolectric.annotation.Implementation;
+import org.robolectric.annotation.Implements;
+
+/**
+ * This shadow is added for the test initWithContext_setupContextListenersNotCompleted_doesNotProduceNPE
+ * Changes the behavior of one method without affecting other unit tests using ShadowOneSignal
+ */
+@Implements(OneSignal.class)
+public class ShadowOneSignalWithMockSetupContextListeners {
+
+   /**
+    * Simulates setupContextListeners() in initWithContext() not completing.
+    * However, languageContext initialization is needed for later, so that is the only code kept
+    */
+   @Implementation
+   public static void setupContextListeners(boolean wasAppContextNull) {
+
+      // Do work here that should only happen once or at the start of a new lifecycle
+      if (wasAppContextNull) {
+         OneSignal.languageContext = new LanguageContext(OneSignal.getSharedPreferences());
+      }
+   }
+}

OneSignalSDK/unittest/src/test/java/com/test/onesignal/OneSignalInitializationIntegrationTestsRunner.java

@@ -7,6 +7,7 @@
 import com.onesignal.ShadowCustomTabsClient;
 import com.onesignal.ShadowCustomTabsSession;
 import com.onesignal.ShadowOSUtils;
+import com.onesignal.ShadowOneSignalWithMockSetupContextListeners;
 import com.onesignal.ShadowOneSignalRestClient;
 import com.onesignal.ShadowPushRegistratorFCM;
 import com.onesignal.StaticResetHelper;
@@ -88,6 +89,19 @@ public void setRequiresUserPrivacyConsent_withTrue_CalledFirst_DoesNOTCreatePlay
         RestClientAsserts.assertRemoteParamsWasTheOnlyNetworkCall();
     }
 
+    // This test reproduces https://github.com/OneSignal/OneSignal-Android-SDK/issues/1514
+    @Test
+    @Config(shadows = { ShadowOneSignalWithMockSetupContextListeners.class })
+    public void initWithContext_setupContextListenersNotCompleted_doesNotProduceNPE() throws Exception {
+        OneSignal.setAppId(APP_ID);
+
+        // call initWithContext() but don't complete setupContextListeners() via the Shadow class
+        // this prevents the initialization of outcomeEventsController in setupContextListeners()
+        helper_OneSignal_initWithAppContext();
+        threadAndTaskWait();
+        // we implicitly test that no exception is thrown
+    }
+
     @Test
     public void setRequiresUserPrivacyConsent_withFalseAndRemoteTrue_DoesNOTCreatePlayer() throws Exception {
         ShadowOneSignalRestClient.setRemoteParamsRequirePrivacyConsent(true);