Fix SQLiteDatabaseLockedException (#1109)

  * Synchronize database due to differents threads trying to modify database
  * Remove database access from other classes that are not OneSignalDBHelper
  * Create query, insert, update, delete methods on OneSignalDBHelper
  * Make OneSignalDBHelper the only responsible of altering db

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/BadgeCountUpdater.java

@@ -27,22 +27,19 @@
 
 package com.onesignal;
 
-import android.app.NotificationManager;
 import android.content.Context;
 import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageManager;
 import android.database.Cursor;
-import android.database.sqlite.SQLiteDatabase;
 import android.os.Build;
 import android.os.Bundle;
 import android.service.notification.StatusBarNotification;
 import android.support.annotation.RequiresApi;
 
+import com.onesignal.OneSignalDbContract.NotificationTable;
 import com.onesignal.shortcutbadger.ShortcutBadgeException;
 import com.onesignal.shortcutbadger.ShortcutBadger;
 
-import com.onesignal.OneSignalDbContract.NotificationTable;
-
 import static com.onesignal.NotificationLimitManager.MAX_NUMBER_OF_NOTIFICATIONS_STR;
 
 class BadgeCountUpdater {
@@ -75,14 +72,14 @@ private static boolean areBadgesEnabled(Context context) {
       return areBadgeSettingsEnabled(context) && OSUtils.areNotificationsEnabled(context);
    }
 
-   static void update(SQLiteDatabase readableDb, Context context) {
+   static void update(OneSignalDb db, Context context) {
       if (!areBadgesEnabled(context))
          return;
 
       if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M)
          updateStandard(context);
       else
-         updateFallback(readableDb, context);
+         updateFallback(db, context);
    }
 
    @RequiresApi(api = Build.VERSION_CODES.M)
@@ -99,8 +96,8 @@ private static void updateStandard(Context context) {
       updateCount(runningCount, context);
    }
 
-   private static void updateFallback(SQLiteDatabase readableDb, Context context) {
-      Cursor cursor = readableDb.query(
+   private static void updateFallback(OneSignalDb db, Context context) {
+      Cursor cursor = db.query(
          NotificationTable.TABLE_NAME,
          null,
          OneSignalDbHelper.recentUninteractedWithNotificationsWhere().toString(),

OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java

@@ -27,20 +27,6 @@
 
 package com.onesignal;
 
-import java.lang.reflect.Field;
-import java.math.BigInteger;
-import java.net.URL;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.List;
-import java.security.SecureRandom;
-import java.util.Random;
-
-import org.json.JSONArray;
-import org.json.JSONException;
-import org.json.JSONObject;
-
 import android.R.drawable;
 import android.app.Activity;
 import android.app.AlertDialog;
@@ -53,7 +39,6 @@
 import android.content.pm.PackageManager;
 import android.content.res.Resources;
 import android.database.Cursor;
-import android.database.sqlite.SQLiteDatabase;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
 import android.net.Uri;
@@ -68,6 +53,20 @@
 
 import com.onesignal.OneSignalDbContract.NotificationTable;
 
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
+
+import java.lang.reflect.Field;
+import java.math.BigInteger;
+import java.net.URL;
+import java.security.SecureRandom;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+import java.util.Random;
+
 import static com.onesignal.OSUtils.getResourceString;
 
 class GenerateNotification {
@@ -528,8 +527,6 @@ private static void createSummaryNotification(NotificationGenerationJob notifJob
       Cursor cursor = null;
 
       try {
-         SQLiteDatabase readableDb = dbHelper.getSQLiteDatabaseWithRetries();
-   
          String[] retColumn = { NotificationTable.COLUMN_NAME_ANDROID_NOTIFICATION_ID,
              NotificationTable.COLUMN_NAME_FULL_DATA,
              NotificationTable.COLUMN_NAME_IS_SUMMARY,
@@ -545,7 +542,7 @@ private static void createSummaryNotification(NotificationGenerationJob notifJob
          if (!updateSummary && notifJob.getAndroidId() != -1)
             whereStr += " AND " + NotificationTable.COLUMN_NAME_ANDROID_NOTIFICATION_ID + " <> " + notifJob.getAndroidId();
 
-         cursor = readableDb.query(
+         cursor = dbHelper.query(
              NotificationTable.TABLE_NAME,
              retColumn,
              whereStr,
@@ -769,28 +766,11 @@ private static Intent createBaseSummaryIntent(int summaryNotificationId, JSONObj
    private static void createSummaryIdDatabaseEntry(OneSignalDbHelper dbHelper, String group, int id) {
       // There currently isn't a visible notification from for this groupid.
       // Save the group summary notification id so it can be updated later.
-      SQLiteDatabase writableDb = null;
-      try {
-         writableDb = dbHelper.getSQLiteDatabaseWithRetries();
-         writableDb.beginTransaction();
-      
-         ContentValues values = new ContentValues();
-         values.put(NotificationTable.COLUMN_NAME_ANDROID_NOTIFICATION_ID, id);
-         values.put(NotificationTable.COLUMN_NAME_GROUP_ID, group);
-         values.put(NotificationTable.COLUMN_NAME_IS_SUMMARY, 1);
-         writableDb.insertOrThrow(NotificationTable.TABLE_NAME, null, values);
-         writableDb.setTransactionSuccessful();
-      } catch (Throwable t) {
-         OneSignal.Log(OneSignal.LOG_LEVEL.ERROR, "Error adding summary notification record! ", t);
-      } finally {
-         if (writableDb != null) {
-            try {
-               writableDb.endTransaction(); // May throw if transaction was never opened or DB is full.
-            } catch (Throwable t) {
-               OneSignal.Log(OneSignal.LOG_LEVEL.ERROR, "Error closing transaction! ", t);
-            }
-         }
-      }
+      ContentValues values = new ContentValues();
+      values.put(NotificationTable.COLUMN_NAME_ANDROID_NOTIFICATION_ID, id);
+      values.put(NotificationTable.COLUMN_NAME_GROUP_ID, group);
+      values.put(NotificationTable.COLUMN_NAME_IS_SUMMARY, 1);
+      dbHelper.insertOrThrow(NotificationTable.TABLE_NAME, null, values);
    }
 
    // Keep 'throws Throwable' as 'onesignal_bgimage_notif_layout' may not be available