Skip to content

Commit eb49eb9

Browse files
committed
Rename OSIAMLifecycleHandler to OSInAppMessageLifecycleHandler
Public facing - spell out IAM
1 parent 9f8481c commit eb49eb9

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66

77
import com.onesignal.OSInAppMessage;
88
import com.onesignal.OSNotification;
9-
import com.onesignal.OSNotificationOpenedResult;
10-
import com.onesignal.OSIAMLifecycleHandler;
9+
import com.onesignal.OSInAppMessageLifecycleHandler;
1110
import com.onesignal.OneSignal;
1211
import com.onesignal.sdktest.R;
1312
import com.onesignal.sdktest.constant.Tag;
@@ -22,7 +21,7 @@ public class MainApplication extends MultiDexApplication {
2221
public void onCreate() {
2322
super.onCreate();
2423

25-
OSIAMLifecycleHandler handler = new OSIAMLifecycleHandler() {
24+
OSInAppMessageLifecycleHandler handler = new OSInAppMessageLifecycleHandler() {
2625
@Override
2726
public void onWillDisplayInAppMessage(OSInAppMessage message) {
2827
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "MainApplication onWillDisplayInAppMessage");
@@ -41,7 +40,7 @@ public void onDidDismissInAppMessage(OSInAppMessage message) {
4140
}
4241
};
4342

44-
OneSignal.setIAMLifecycleHandler(handler);
43+
OneSignal.setInAppMessageLifecycleHandler(handler);
4544

4645
OneSignal.setLogLevel(OneSignal.LOG_LEVEL.VERBOSE, OneSignal.LOG_LEVEL.NONE);
4746

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSIAMLifecycleHandler.java renamed to OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageLifecycleHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@
2727

2828
package com.onesignal;
2929

30-
public abstract class OSIAMLifecycleHandler {
30+
public abstract class OSInAppMessageLifecycleHandler {
3131
public void onWillDisplayInAppMessage(OSInAppMessage message) {
32-
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSIAMLifecycleHandler: IAM Will Display: " + message.getMessageId());
32+
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageLifecycleHandler: IAM Will Display: " + message.getMessageId());
3333
}
3434
public void onDidDisplayInAppMessage(OSInAppMessage message) {
35-
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSIAMLifecycleHandler: IAM Did Display: " + message.getMessageId());
35+
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageLifecycleHandler: IAM Did Display: " + message.getMessageId());
3636
}
3737
public void onWillDismissInAppMessage(OSInAppMessage message) {
38-
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSIAMLifecycleHandler: IAM Will Dismiss: " + message.getMessageId());
38+
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageLifecycleHandler: IAM Will Dismiss: " + message.getMessageId());
3939
}
4040
public void onDidDismissInAppMessage(OSInAppMessage message) {
41-
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSIAMLifecycleHandler: IAM Did Dismiss: " + message.getMessageId());
41+
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageLifecycleHandler: IAM Did Dismiss: " + message.getMessageId());
4242
}
4343
}

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ static Activity getCurrentActivity() {
376376
static OSNotificationWillShowInForegroundHandler notificationWillShowInForegroundHandler;
377377
static OSNotificationOpenedHandler notificationOpenedHandler;
378378
static OSInAppMessageClickHandler inAppMessageClickHandler;
379-
static OSIAMLifecycleHandler inAppMessageLifecycleHandler;
379+
static OSInAppMessageLifecycleHandler inAppMessageLifecycleHandler;
380380

381381
// Is the init() of OneSignal SDK finished yet
382382
private static boolean initDone;
@@ -741,7 +741,7 @@ public static void setNotificationWillShowInForegroundHandler(@Nullable OSNotifi
741741
notificationWillShowInForegroundHandler = callback;
742742
}
743743

744-
public static void setIAMLifecycleHandler(@Nullable OSIAMLifecycleHandler handler) {
744+
public static void setInAppMessageLifecycleHandler(@Nullable OSInAppMessageLifecycleHandler handler) {
745745
inAppMessageLifecycleHandler = handler;
746746
}
747747

OneSignalSDK/unittest/src/test/java/com/test/onesignal/InAppMessagingUnitTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import com.onesignal.InAppMessagingHelpers;
99
import com.onesignal.MockOSTimeImpl;
10-
import com.onesignal.OSIAMLifecycleHandler;
10+
import com.onesignal.OSInAppMessageLifecycleHandler;
1111
import com.onesignal.OSInAppMessage;
1212
import com.onesignal.OSInAppMessageAction;
1313
import com.onesignal.OneSignal;
@@ -642,7 +642,7 @@ public void testOnPageChanged() throws Exception {
642642
private static int iamLifecycleCounter;
643643
@Test
644644
public void testIAMLifecycleEventsFlow() throws Exception {
645-
OneSignal.setIAMLifecycleHandler(new OSIAMLifecycleHandler() {
645+
OneSignal.setInAppMessageLifecycleHandler(new OSInAppMessageLifecycleHandler() {
646646
@Override
647647
public void onWillDisplayInAppMessage(OSInAppMessage message) {
648648
lastMessage = message;

0 commit comments

Comments
 (0)