Skip to content

Commit e5a748c

Browse files
committed
Fire onSubscriptionChanged event for all subscription types
We only want to fire the changeHandlersNotifier for push subs but the onSubscriptionChanged for all subscriptions.
1 parent ac3a2ab commit e5a748c

File tree

1 file changed

+9
-8
lines changed
  • OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/subscriptions/impl

1 file changed

+9
-8
lines changed

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/subscriptions/impl/SubscriptionManager.kt

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,16 @@ internal class SubscriptionManager(
131131
// this shouldn't happen, but create a new subscription if a model was updated and we
132132
// don't yet have a representation for it in the subscription list.
133133
createSubscriptionAndAddToSubscriptionList(args.model as SubscriptionModel)
134-
} else if (subscription is PushSubscription) {
135-
subscription.changeHandlersNotifier.fireOnMain {
136-
it.onPushSubscriptionChange(
137-
PushSubscriptionChangedState(
138-
subscription.savedState,
139-
subscription.refreshState())
140-
)
134+
} else {
135+
if (subscription is PushSubscription) {
136+
subscription.changeHandlersNotifier.fireOnMain {
137+
it.onPushSubscriptionChange(
138+
PushSubscriptionChangedState(
139+
subscription.savedState,
140+
subscription.refreshState())
141+
)
142+
}
141143
}
142-
143144
// the model has already been updated, so fire the update event
144145
_events.fire { it.onSubscriptionChanged(subscription, args) }
145146
}

0 commit comments

Comments
 (0)