Skip to content

Commit dc5e26a

Browse files
committed
Fixed NPE when no tags available
``` 02-15 21:38:30.059 18892-19027/com.my.app E/unknown:React: Exception in native call from JS java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.json.JSONObject.toString()' on a null object reference at com.onesignal.OneSignal.getTags(OneSignal.java:732) at com.my.app.reactnativeonesignal.RNOneSignal.getTags(RNOneSignal.java:69) at java.lang.reflect.Method.invoke(Native Method) at java.lang.reflect.Method.invoke(Method.java:372) at com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke(BaseJavaModule.java:249) at com.facebook.react.bridge.NativeModuleRegistry$ModuleDefinition.call(NativeModuleRegistry.java:158) at com.facebook.react.bridge.NativeModuleRegistry.call(NativeModuleRegistry.java:58) at com.facebook.react.bridge.CatalystInstanceImpl$NativeModulesReactCallback.call(CatalystInstanceImpl.java:431) at com.facebook.react.bridge.queue.NativeRunnableDeprecated.run(Native Method) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31) at android.os.Looper.loop(Looper.java:135) at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:185) at java.lang.Thread.run(Thread.java:818) ```
1 parent a472349 commit dc5e26a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ void onFailure(int statusCode, String response, Throwable throwable) {
729729

730730
public static void getTags(final GetTagsHandler getTagsHandler) {
731731
JSONObject tags = OneSignalStateSynchronizer.getTags();
732-
if (tags.toString().equals("{}"))
732+
if (tags == null || tags.toString().equals("{}"))
733733
getTagsHandler.tagsAvailable(null);
734734
else
735735
getTagsHandler.tagsAvailable(OneSignalStateSynchronizer.getTags());

0 commit comments

Comments
 (0)