[User Model] Safeguard against activities/services/receivers being called before initialization.

* Update `IOneSignal.initWithContext` interface to return whether initialization was successful or not.
* Implementation fails initialization if no app ID is provided and no app ID has been saved.
* Update all activities/services/receivers to check and not proceed when initialization unsuccessful.

Author: brismithers

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/IOneSignal.kt

@@ -80,8 +80,10 @@ interface IOneSignal {
      *
      * @param context The Android context the SDK should use.
      * @param appId The application ID the OneSignal SDK is bound to.
+     *
+     * @return true if the SDK could be successfully initialized, false otherwise.
      */
-    fun initWithContext(context: Context, appId: String?)
+    fun initWithContext(context: Context, appId: String?) : Boolean
 
     /**
      * Login to OneSignal under the user identified by the [externalId] provided. The act of

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/OneSignal.kt

@@ -192,8 +192,8 @@ object OneSignal {
      * THIS IS AN INTERNAL INTERFACE AND SHOULD NOT BE USED DIRECTLY.
      */
     @JvmStatic
-    fun initWithContext(context: Context) {
-        oneSignal.initWithContext(context, null)
+    fun initWithContext(context: Context) : Boolean {
+        return oneSignal.initWithContext(context, null)
     }
 
     /**

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/activities/PermissionsActivity.kt

@@ -22,7 +22,10 @@ class PermissionsActivity : Activity() {
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        OneSignal.initWithContext(this)
+        
+        if(!OneSignal.initWithContext(this)) {
+            return
+        }
 
         _requestPermissionService = OneSignal.getService()
         _preferenceService = OneSignal.getService()

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/services/SyncJobService.kt

@@ -38,7 +38,9 @@ import com.onesignal.debug.internal.logging.Logging
 @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP)
 class SyncJobService : JobService() {
     override fun onStartJob(jobParameters: JobParameters): Boolean {
-        OneSignal.initWithContext(this)
+        if(!OneSignal.initWithContext(this)) {
+            return false
+        }
 
         var backgroundService = OneSignal.getService<IBackgroundManager>()
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/services/SyncService.kt

@@ -36,7 +36,9 @@ import com.onesignal.debug.internal.logging.Logging
 
 class SyncService : Service() {
     override fun onStartCommand(intent: Intent, flags: Int, startId: Int): Int {
-        OneSignal.initWithContext(this)
+        if(!OneSignal.initWithContext(this)) {
+            return START_STICKY
+        }
 
         var backgroundService = OneSignal.getService<IBackgroundManager>()
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt

@@ -135,12 +135,12 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
         _services = serviceBuilder.build()
     }
 
-    override fun initWithContext(context: Context, appId: String?) {
+    override fun initWithContext(context: Context, appId: String?) : Boolean {
         Logging.log(LogLevel.DEBUG, "initWithContext(context: $context, appId: $appId)")
 
         // do not do this again if already initialized
         if (isInitialized) {
-            return
+            return true
         }
 
         // start the application service. This is called explicitly first because we want
@@ -156,6 +156,14 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
         _configModel = _services.getService<ConfigModelStore>().model
         _sessionModel = _services.getService<SessionModelStore>().model
 
+        // initWithContext is called by our internal services/receivers/activites but they do not provide
+        // an appId (they don't know it).  If the app has never called the external initWithContext
+        // prior to our services/receivers/activities we will blow up, as no appId has been established.
+        if (appId == null && !_configModel!!.hasProperty(ConfigModel::appId.name)) {
+            Logging.warn("initWithContext called without providing appId, and no appId has been established!")
+            return false
+        }
+
         var forceCreateUser = false
         // if the app id was specified as input, update the config model with it
         if (appId != null) {
@@ -239,6 +247,8 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
         _startupService!!.start()
 
         isInitialized = true
+
+        return true
     }
 
     override fun login(externalId: String, jwtBearerToken: String?) {

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/activities/NotificationOpenedActivityBase.kt

@@ -36,7 +36,9 @@ import com.onesignal.notifications.internal.open.INotificationOpenedProcessor
 abstract class NotificationOpenedActivityBase : Activity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        OneSignal.initWithContext(applicationContext)
+        if(!OneSignal.initWithContext(applicationContext)) {
+            return
+        }
 
         var self = this
 
@@ -50,7 +52,9 @@ abstract class NotificationOpenedActivityBase : Activity() {
 
     override fun onNewIntent(intent: Intent) {
         super.onNewIntent(intent)
-        OneSignal.initWithContext(applicationContext)
+        if(!OneSignal.initWithContext(applicationContext)) {
+            return
+        }
 
         var self = this
         suspendifyOnThread {

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/activities/NotificationOpenedActivityHMS.kt

@@ -72,7 +72,9 @@ class NotificationOpenedActivityHMS : Activity() {
     }
 
     private fun processOpen(intent: Intent?) {
-        OneSignal.initWithContext(applicationContext)
+        if (!OneSignal.initWithContext(applicationContext)) {
+            return
+        }
 
         var notificationPayloadProcessorHMS = OneSignal.getService<INotificationOpenedProcessorHMS>()
         val self = this

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/bridges/OneSignalHmsEventBridge.kt

@@ -53,7 +53,9 @@ object OneSignalHmsEventBridge {
     }
 
     fun onMessageReceived(context: Context, message: RemoteMessage) {
-        OneSignal.initWithContext(context)
+        if(!OneSignal.initWithContext(context)) {
+            return
+        }
 
         var time = OneSignal.getService<ITime>()
         val bundleProcessor = OneSignal.getService<INotificationBundleProcessor>()

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/internal/restoration/impl/NotificationRestoreWorkManager.kt

@@ -45,8 +45,8 @@ internal class NotificationRestoreWorkManager : INotificationRestoreWorkManager
         override suspend fun doWork(): Result {
             val context = applicationContext
 
-            if (!OneSignal.isInitialized) {
-                OneSignal.initWithContext(context)
+            if (!OneSignal.initWithContext(context)) {
+                return Result.success();
             }
 
             if (!NotificationHelper.areNotificationsEnabled(context)) {