Skip to content

Commit d865c22

Browse files
committed
removing page id check in pageChanged
1 parent 0479008 commit d865c22

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageAction.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ public String getClickName() {
133133
return clickName;
134134
}
135135

136-
@NonNull
137136
String getPageId() {
138137
return pageId;
139138
}

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageController.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,9 +286,6 @@ void onPageChanged(@NonNull final OSInAppMessage message, @NonNull final JSONObj
286286
if (message.isPreview) {
287287
return;
288288
}
289-
if (message.getViewedPageIds().contains(newPage.getPageId())) {
290-
return;
291-
}
292289
fireRESTCallForPageChange(message, newPage);
293290
}
294291

@@ -427,7 +424,6 @@ private void fireRESTCallForPageChange(@NonNull final OSInAppMessage message, @N
427424

428425
final String pageId = page.getPageId();
429426

430-
431427
// Never send multiple page impressions for the same message UUID unless that page change is from an IAM with redisplay
432428
if (message.getViewedPageIds().contains(pageId))
433429
return;

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessagePage.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class OSInAppMessagePage constructor(jsonObject: JSONObject) {
1616
pageIndex = jsonObject.optString(PAGE_INDEX, null)
1717
}
1818

19-
fun toJSONObject(): JSONObject? {
19+
fun toJSONObject(): JSONObject {
2020
val mainObj = JSONObject()
2121
try {
2222
mainObj.put(PAGE_ID, pageId)

0 commit comments

Comments
 (0)