Skip to content

Commit d68ba38

Browse files
committed
version bump and unit test fix for getTags
1 parent 55b2242 commit d68ba38

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

OneSignalSDK/app/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,6 @@ public void testUserDeletedFromServer() throws Exception {
475475
OneSignalInit();
476476
threadAndTaskWait();
477477

478-
System.out.println("ShadowOneSignalRestClient.lastPost: " + ShadowOneSignalRestClient.lastPost);
479478
Assert.assertEquals(normalCreateFieldCount, ShadowOneSignalRestClient.lastPost.length());
480479

481480

@@ -486,7 +485,6 @@ public void testUserDeletedFromServer() throws Exception {
486485
OneSignal.sendTag("key1", "value1");
487486
threadAndTaskWait();
488487

489-
System.out.println("ShadowOneSignalRestClient.lastPost: " + ShadowOneSignalRestClient.lastPost);
490488
Assert.assertEquals(normalCreateFieldCount, ShadowOneSignalRestClient.lastPost.length() - 1);
491489
}
492490

@@ -552,7 +550,6 @@ public void tagsAvailable(JSONObject tags) {
552550
threadAndTaskWait();
553551
threadAndTaskWait();
554552

555-
System.out.println("lastGetTags: " + lastGetTags);
556553
Assert.assertEquals("value1", lastGetTags.getString("test1"));
557554
Assert.assertEquals("value2", lastGetTags.getString("test2"));
558555
Assert.assertEquals(2, ShadowOneSignalRestClient.networkCallCount);
@@ -568,24 +565,19 @@ public void testOldIntValues() throws Exception {
568565

569566
OneSignalInit();
570567
threadAndTaskWait();
571-
System.out.println("Saved state: " + prefs.getString("ONESIGNAL_USERSTATE_SYNCVALYES_CURRENT_STATE", null));
572-
System.out.println("Deleting tag");
568+
573569
OneSignal.deleteTag("int");
574570
threadAndTaskWait();
575571

576572
lastGetTags = null;
577573
OneSignal.getTags(new OneSignal.GetTagsHandler() {
578574
@Override
579575
public void tagsAvailable(JSONObject tags) {
580-
System.out.println("tags: " + tags);
581576
lastGetTags = tags;
582577
}
583578
});
584579

585580
final SharedPreferences prefs2 = blankActivity.getSharedPreferences(OneSignal.class.getSimpleName(), Context.MODE_PRIVATE);
586-
System.out.println("Saved state: " + prefs2.getString("ONESIGNAL_USERSTATE_SYNCVALYES_CURRENT_STATE", null));
587-
588-
System.out.println("lastGetTags: " + lastGetTags);
589581
Assert.assertNull(lastGetTags);
590582
}
591583

@@ -600,8 +592,6 @@ public void tagsAvailable(JSONObject tags) {
600592
}
601593
});
602594

603-
System.out.println(lastGetTags);
604-
605595
Assert.assertEquals(String.class, lastGetTags.get("int").getClass());
606596
Assert.assertEquals("122", lastGetTags.get("int"));
607597
Assert.assertEquals(String.class, lastGetTags.get("bool").getClass());
@@ -692,7 +682,6 @@ public void tagsAvailable(JSONObject tags) {
692682
}
693683
});
694684

695-
System.out.println("lastGetTags: " + lastGetTags);
696685
Assert.assertFalse(lastGetTags.has("int"));
697686
lastGetTags = null;
698687

@@ -710,7 +699,6 @@ public void tagsAvailable(JSONObject tags) {
710699
}
711700
});
712701

713-
System.out.println("lastGetTags: " + lastGetTags);
714702
Assert.assertFalse(lastGetTags.has("int"));
715703

716704
// After the success response it should not store a "" string when saving to storage.
@@ -732,7 +720,7 @@ public void testOmitDeletesOfNonExistingKeys() throws Exception {
732720

733721

734722
// ####### GetTags Tests ########
735-
723+
@Test
736724
public void testGetTagsWithNoTagsShouldBeNull() throws Exception {
737725
OneSignalInit();
738726
OneSignal.getTags(new OneSignal.GetTagsHandler() {

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public void init() {
155155
private static TrackGooglePurchase trackGooglePurchase;
156156
private static TrackAmazonPurchase trackAmazonPurchase;
157157

158-
public static final String VERSION = "020100";
158+
public static final String VERSION = "020101";
159159

160160
private static AdvertisingIdentifierProvider mainAdIdProvider = new AdvertisingIdProviderGPS();
161161

0 commit comments

Comments
 (0)