Skip to content

Commit d46baf8

Browse files
committed
Added null handler check to getTags
1 parent 24517ca commit d46baf8

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

OneSignalSDK/app/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -754,6 +754,12 @@ public void testGetTagsWithNoTagsShouldBeNull() throws Exception {
754754
Assert.assertNull(lastGetTags);
755755
}
756756

757+
@Test
758+
public void testGetTagNullCheck() throws Exception {
759+
OneSignalInit();
760+
OneSignal.getTags(null);
761+
}
762+
757763
@Test
758764
public void shouldGetTags() throws Exception {
759765
OneSignalInit();

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,10 @@ public static void getTags(final GetTagsHandler getTagsHandler) {
734734
Log(LOG_LEVEL.ERROR, "You must initialize OneSignal before getting tags! Omitting this tag operation.");
735735
return;
736736
}
737+
if (getTagsHandler == null) {
738+
Log(LOG_LEVEL.ERROR, "getTagsHandler is null!");
739+
return;
740+
}
737741

738742
JSONObject tags = OneSignalStateSynchronizer.getTags();
739743
if (tags == null || tags.toString().equals("{}"))

0 commit comments

Comments
 (0)