Fix onSuccess callbacks for setting email, SMS

- Don't call the `onSuccess` callbacks for `setEmail` and `setSMSNumber` within the push synchronizer.

- Previously, this callback may be triggered before the email or sms player is actually created or saved to the SDK through calls to `saveChannelId` (ie `saveEmailId` or `saveSMSId`)

- The UserStateEmailSynchronizer or UserStateSMSSynchronizer will call these `onSuccess` callbacks later.

- For the unhappy path for the failure callbacks, leave that as it is.

Author: nan-li

OneSignalSDK/onesignal/src/main/java/com/onesignal/UserStatePushSynchronizer.java

@@ -229,19 +229,7 @@ protected void fireEventsForUpdateFailure(JSONObject jsonFields) {
 
     @Override
     protected void onSuccessfulSync(JSONObject jsonFields) {
-        if (jsonFields.has(EMAIL_KEY))
-            OneSignal.fireEmailUpdateSuccess();
-
-        if (jsonFields.has(SMS_NUMBER_KEY)) {
-            JSONObject result = new JSONObject();
-            try {
-                result.put(SMS_NUMBER_KEY, jsonFields.get(SMS_NUMBER_KEY));
-                if (jsonFields.has(SMS_AUTH_HASH_KEY))
-                    result.put(SMS_AUTH_HASH_KEY, jsonFields.get(SMS_AUTH_HASH_KEY));
-            } catch (JSONException e) {
-                e.printStackTrace();
-            }
-            OneSignal.fireSMSUpdateSuccess(result);
-        }
+        // Previously, the onSuccess callbacks for setEmail and setSMSNumber were triggered here if applicable.
+        // However, this is too early, and the UserStateSecondaryChannelSynchronizer will fire the successful callback.
     }
 }