Skip to content

Commit c0bf59d

Browse files
committed
Locking down Log method and cast fix.
* Locking down Log methods as these are designed to be used inferentially only. - Cleaned up cast inside for consistency and to enforce compile time safety.
1 parent b05676b commit c0bf59d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -339,16 +339,16 @@ private static OneSignal.LOG_LEVEL getLogLevel(int level) {
339339
private static boolean atLogLevel(LOG_LEVEL level) {
340340
return level.compareTo(visualLogLevel) < 1 || level.compareTo(logCatLevel) < 1;
341341
}
342-
343-
public static void Log(LOG_LEVEL level, String message) {
342+
343+
static void Log(LOG_LEVEL level, String message) {
344344
Log(level, message, null, appContext);
345345
}
346346

347-
public static void Log(final LOG_LEVEL level, String message, Throwable throwable) {
347+
static void Log(final LOG_LEVEL level, String message, Throwable throwable) {
348348
Log(level, message, throwable, appContext);
349349
}
350350

351-
public static void Log(final LOG_LEVEL level, String message, Throwable throwable, final Context context) {
351+
private static void Log(final LOG_LEVEL level, String message, Throwable throwable, final Activity context) {
352352
if (level.compareTo(logCatLevel) < 1) {
353353
if (level == LOG_LEVEL.VERBOSE)
354354
Log.v(TAG, message, throwable);
@@ -375,7 +375,7 @@ else if (level == LOG_LEVEL.ERROR || level == LOG_LEVEL.FATAL)
375375

376376
final String finalFullMessage = fullMessage;
377377

378-
((Activity)context).runOnUiThread(new Runnable() {
378+
context.runOnUiThread(new Runnable() {
379379
@Override
380380
public void run() {
381381
new AlertDialog.Builder(context)

0 commit comments

Comments
 (0)