Fix suppressLaunchURLs not working

  * suppressLaunchURLs Manifest value is boolean, code was trying to parse a String value
  * Update test to make it fail, then fix parsing issue

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSUtils.java

@@ -402,13 +402,31 @@ String getCarrierName() {
       }
    }
 
-   static String getManifestMeta(Context context, String metaName) {
+   static Bundle getManifestMetaBundle(Context context) {
+
+      ApplicationInfo ai = null;
       try {
-         ApplicationInfo ai = context.getPackageManager().getApplicationInfo(context.getPackageName(), PackageManager.GET_META_DATA);
-         Bundle bundle = ai.metaData;
+         ai = context.getPackageManager().getApplicationInfo(context.getPackageName(), PackageManager.GET_META_DATA);
+      } catch (PackageManager.NameNotFoundException e) {
+         Log(OneSignal.LOG_LEVEL.ERROR, "Manifest application info not found", e);
+      }
+
+      return null;
+   }
+
+   static boolean getManifestMetaBoolean(Context context, String metaName) {
+      Bundle bundle = getManifestMetaBundle(context);
+      if (bundle != null) {
+         return bundle.getBoolean(metaName);
+      }
+
+      return false;
+   }
+
+   static String getManifestMeta(Context context, String metaName) {
+      Bundle bundle = getManifestMetaBundle(context);
+      if (bundle != null) {
          return bundle.getString(metaName);
-      } catch (Throwable t) {
-         Log(OneSignal.LOG_LEVEL.ERROR, "", t);
       }
 
       return null;

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

@@ -2141,7 +2141,7 @@ private static boolean openURLFromNotification(Context context, JSONArray dataAr
       int jsonArraySize = dataArray.length();
 
       boolean urlOpened = false;
-      boolean launchUrlSuppress = "true".equals(OSUtils.getManifestMeta(context, "com.onesignal.suppressLaunchURLs"));
+      boolean launchUrlSuppress = OSUtils.getManifestMetaBoolean(context, "com.onesignal.suppressLaunchURLs");
 
       for (int i = 0; i < jsonArraySize; i++) {
          try {

OneSignalSDK/unittest/src/test/java/com/onesignal/OneSignalShadowPackageManager.java

@@ -44,6 +44,8 @@ public static void resetStatics() {
     public static void addManifestMetaData(String key, Object value) {
         if (value instanceof String) {
             metaData.putString(key, value.toString());
+        } else if (value instanceof Boolean) {
+            metaData.putBoolean(key, (Boolean) value);
         } else {
             // TODO: We should add any other cases we have for different values here
         }

OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

@@ -1110,13 +1110,24 @@ public void testDisableOpeningLauncherActivityOnNotificationOpen() throws Except
    @Test
    public void testLaunchUrlSuppressTrue() throws Exception {
       // Add the 'com.onesignal.suppressLaunchURLs' as 'true' meta-data tag
-      OneSignalShadowPackageManager.addManifestMetaData("com.onesignal.suppressLaunchURLs", "true");
+      // First init run for appId to be saved
+      // At least OneSignal was init once for user to be subscribed
+      // If this doesn't' happen, notifications will not arrive
+      OneSignalInit();
+      fastColdRestartApp();
+
+      // Add the 'com.onesignal.suppressLaunchURLs' as 'true' meta-data tag
+      OneSignalShadowPackageManager.addManifestMetaData("com.onesignal.suppressLaunchURLs", true);
 
       // Removes app launch
       shadowOf(blankActivity).getNextStartedActivity();
 
-      // No OneSignal init here to test case where it is located in an Activity.
+      // Init with context since this is call before calling OneSignal_handleNotificationOpen internally
+      OneSignal.initWithContext(blankActivity);
+
       OneSignal_handleNotificationOpen(blankActivity, new JSONArray("[{ \"alert\": \"Test Msg\", \"custom\": { \"i\": \"UUID\", \"u\": \"http://google.com\" } }]"), false, ONESIGNAL_NOTIFICATION_ID);
+      threadAndTaskWait();
+
       assertNull(shadowOf(blankActivity).getNextStartedActivity());
    }
 
@@ -1128,13 +1139,19 @@ public void testLaunchUrlSuppressFalse() throws Exception {
       // If this doesn't' happen, notifications will not arrive
       OneSignalInit();
       fastColdRestartApp();
-      OneSignalShadowPackageManager.addManifestMetaData("com.onesignal.suppressLaunchURLs", "false");
+
+      OneSignalShadowPackageManager.addManifestMetaData("com.onesignal.suppressLaunchURLs", false);
       OneSignal.initWithContext(blankActivity);
+
       // Removes app launch
       shadowOf(blankActivity).getNextStartedActivity();
 
-      // No OneSignal init here to test case where it is located in an Activity.
+      // Init with context since this is call before calling OneSignal_handleNotificationOpen internally
+      OneSignal.initWithContext(blankActivity);
+
       OneSignal_handleNotificationOpen(blankActivity, new JSONArray("[{ \"alert\": \"Test Msg\", \"custom\": { \"i\": \"UUID\", \"u\": \"http://google.com\" } }]"), false, ONESIGNAL_NOTIFICATION_ID);
+      threadAndTaskWait();
+
       Intent intent = shadowOf(blankActivity).getNextStartedActivity();
       assertEquals("android.intent.action.VIEW", intent.getAction());
       assertEquals("http://google.com", intent.getData().toString());