Skip to content

Commit bf091c8

Browse files
authored
Merge pull request #872 from OneSignal/fix_flaky_waiting_of_threads_in_tests
Add a 2nd run of runOSThreads if first didn't find
2 parents 5099bcb + 5da1fdc commit bf091c8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

OneSignalSDK/unittest/src/test/java/com/test/onesignal/TestHelpers.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,8 @@ static void threadAndTaskWait() throws Exception {
173173

174174
boolean createdNewThread;
175175
do {
176-
createdNewThread = runOSThreads();
176+
// We run a 2nd time if we did not find any threads to ensure we don't skip any
177+
createdNewThread = runOSThreads() || runOSThreads();
177178

178179
boolean advancedRunnables = OneSignalPackagePrivateHelper.runAllNetworkRunnables();
179180
advancedRunnables = OneSignalPackagePrivateHelper.runFocusRunnables() || advancedRunnables;

0 commit comments

Comments
 (0)