Skip to content

Commit b62b895

Browse files
committed
Merge from user-model/main
2 parents 5124ed0 + f1f7bcb commit b62b895

File tree

239 files changed

+991
-937
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

239 files changed

+991
-937
lines changed

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/adapter/PairRecyclerViewAdapter.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ private void populateInterfaceElements(final int position) {
8181

8282
if (Util.isBoolean(value))
8383
value += " (bool)";
84-
else if (Util.isNumeric(value))
85-
value += " (num)";
84+
else if (Util.isInteger(value))
85+
value += " (int)";
86+
else if (Util.isFloat(value))
87+
value += " (float)";
8688
else
8789
value += " (str)";
8890
pairValueTextView.setText(value);

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/adapter/SingleRecyclerViewAdapter.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,10 @@ private void populateInterfaceElements(final int position) {
7676

7777
if (Util.isBoolean(value))
7878
value += " (bool)";
79-
else if (Util.isNumeric(value))
80-
value += " (num)";
79+
else if (Util.isInteger(value))
80+
value += " (int)";
81+
else if (Util.isFloat(value))
82+
value += " (float)";
8183
else
8284
value += " (str)";
8385
singleTextView.setText(value);

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/model/MainActivityViewModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ public void onSuccess(Pair<String, Object> pair) {
719719
triggerSet.remove(pair.first);
720720
toaster.makeCustomViewToast("Deleted trigger " + pair.first, ToastType.SUCCESS);
721721
} else {
722-
OneSignal.getInAppMessages().addTrigger(pair.first, pair.second);
722+
OneSignal.getInAppMessages().addTrigger(pair.first, pair.second.toString());
723723
triggerSet.put(pair.first, pair.second);
724724
toaster.makeCustomViewToast("Added trigger " + pair.first, ToastType.SUCCESS);
725725
}

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/util/Dialog.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,9 @@ public void onClick(final DialogInterface dialog, int which) {
167167
Object pairValue = pairStringValue;
168168
if (Util.isBoolean(pairStringValue)) {
169169
pairValue = Boolean.parseBoolean(pairStringValue.toLowerCase());
170-
} else if (Util.isNumeric(pairStringValue)) {
170+
} else if (Util.isInteger(pairStringValue)) {
171+
pairValue = Long.parseLong(pairStringValue);
172+
} else if (Util.isFloat(pairStringValue)) {
171173
pairValue = Double.parseDouble(pairStringValue);
172174
}
173175

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/util/Util.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,16 @@ public static boolean isBoolean(String string) {
77
return (string.equals("true") || string.equals("false"));
88
}
99

10-
public static boolean isNumeric(String string) {
10+
public static boolean isInteger(String string) {
11+
try {
12+
Long.parseLong(string);
13+
return true;
14+
} catch (NumberFormatException e) {
15+
return false;
16+
}
17+
}
18+
19+
public static boolean isFloat(String string) {
1120
try {
1221
Double.parseDouble(string);
1322
return true;

OneSignalSDK/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ buildscript {
1515
huaweiHMSLocationVersion = '4.0.0.300'
1616
kotlinVersion = '1.7.10'
1717
kotestVersion = '5.5.0'
18-
ktlintVersion = '11.0.0'
18+
ktlintPluginVersion = '11.3.1'
19+
ktlintVersion = '0.48.2'
1920
detektVersion = '1.21.0'
2021
junitVersion = '4.13.2'
2122
}
@@ -32,7 +33,7 @@ buildscript {
3233
classpath "com.google.gms:google-services:$googleServicesGradlePluginVersion"
3334
classpath "com.huawei.agconnect:agcp:$huaweiAgconnectVersion"
3435
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
35-
classpath "org.jlleitschuh.gradle:ktlint-gradle:$ktlintVersion"
36+
classpath "org.jlleitschuh.gradle:ktlint-gradle:$ktlintPluginVersion"
3637
classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:$detektVersion"
3738
}
3839
}

OneSignalSDK/onesignal/core/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,4 +90,8 @@ dependencies {
9090
testImplementation("org.jetbrains.kotlin:kotlin-reflect:$kotlinVersion")
9191
}
9292

93+
ktlint {
94+
version = "$ktlintVersion"
95+
}
96+
9397
apply from: '../maven-push.gradle'

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/Continue.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class ContinueResult<R> (
2626
/**
2727
* The throwable that was thrown by the coroutine. This will be `null` if [isSuccess] is `true`.
2828
*/
29-
val throwable: Throwable?
29+
val throwable: Throwable?,
3030
)
3131

3232
/**

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/IOneSignal.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ interface IOneSignal {
8383
*
8484
* @return true if the SDK could be successfully initialized, false otherwise.
8585
*/
86-
fun initWithContext(context: Context, appId: String?) : Boolean
86+
fun initWithContext(context: Context, appId: String?): Boolean
8787

8888
/**
8989
* Login to OneSignal under the user identified by the [externalId] provided. The act of

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/OneSignal.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ object OneSignal {
192192
* THIS IS AN INTERNAL INTERFACE AND SHOULD NOT BE USED DIRECTLY.
193193
*/
194194
@JvmStatic
195-
fun initWithContext(context: Context) : Boolean {
195+
fun initWithContext(context: Context): Boolean {
196196
return oneSignal.initWithContext(context, null)
197197
}
198198

0 commit comments

Comments
 (0)