Skip to content

Commit b27ac14

Browse files
committed
rm isTaskRoot & NEW_TASK flag from notifi open
* Cleans up unneeded logic and confirmed no behavior changes. * `FLAG_ACTIVITY_NEW_TASK` is not needed as `getLaunchIntentForPackage` already defaults this. - See Android ASOP source code - Android 11 - https://cs.android.com/android/platform/superproject/+/android-11.0.0_r3:frameworks/base/core/java/android/app/ApplicationPackageManager.java;l=251 - Android 4 - https://cs.android.com/android/platform/superproject/+/android-4.0.4_r2.1:frameworks/base/core/java/android/app/ApplicationPackageManager.java;l=121
1 parent 0326d93 commit b27ac14

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2174,12 +2174,7 @@ static boolean startOrResumeApp(Activity inContext) {
21742174
logger.debug("startOrResumeApp from context: " + inContext + " isRoot: " + inContext.isTaskRoot() + " with launchIntent: " + launchIntent);
21752175
// Make sure we have a launcher intent.
21762176
if (launchIntent != null) {
2177-
if (inContext.isTaskRoot()) {
2178-
inContext.startActivity(launchIntent);
2179-
} else {
2180-
launchIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
2181-
inContext.startActivity(launchIntent);
2182-
}
2177+
inContext.startActivity(launchIntent);
21832178
return true;
21842179
}
21852180

0 commit comments

Comments
 (0)