Skip to content

Commit af0251e

Browse files
emawbynan-li
authored andcommitted
Fixing liquid templating unit test after moving impression request
1 parent 4759539 commit af0251e

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

OneSignalSDK/unittest/src/test/java/com/test/onesignal/InAppMessageIntegrationTests.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1898,10 +1898,13 @@ public void testLiquidIAMDisplayWaitsForGetTags() throws Exception {
18981898
threadAndTaskWait();
18991899
// Runnable for webView is run from background thread to main thread
19001900
threadAndTaskWait();
1901-
// Check impression request
1902-
requestSize = ShadowOneSignalRestClient.requests.size();
1903-
ShadowOneSignalRestClient.Request iamImpressionRequest = ShadowOneSignalRestClient.requests.get(requestSize - 1);
1904-
assertEquals("in_app_messages/" + message.messageId + "/impression", iamImpressionRequest.url);
1901+
ShadowOneSignalRestClient.Request lastRequest = ShadowOneSignalRestClient.requests.get(ShadowOneSignalRestClient.requests.size() - 1);
1902+
while (!lastRequest.url.equals("in_app_messages/" + message.messageId + "/impression")) {
1903+
// Check impression request by waiting until animationEnd
1904+
threadAndTaskWait();
1905+
lastRequest = ShadowOneSignalRestClient.requests.get(ShadowOneSignalRestClient.requests.size() - 1);
1906+
}
1907+
assertEquals("in_app_messages/" + message.messageId + "/impression", lastRequest.url);
19051908
}
19061909

19071910
private void setMockRegistrationResponseWithMessages(ArrayList<OSTestInAppMessageInternal> messages) throws JSONException {

0 commit comments

Comments
 (0)