Skip to content

Commit ab6fe90

Browse files
committed
Update InAppMessageClickEvent/Result
Change click listener param to `event` and event variable names from `action` to `result`
1 parent 1f15b7a commit ab6fe90

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void onDidDismiss(@NonNull IInAppMessageDidDismissEvent event) {
7878

7979
OneSignal.getInAppMessages().addClickListener(new IInAppMessageClickListener() {
8080
@Override
81-
public void onClick(@Nullable IInAppMessageClickEvent result) {
81+
public void onClick(@Nullable IInAppMessageClickEvent event) {
8282
Log.v(Tag.LOG_TAG, "INotificationClickListener.inAppMessageClicked");
8383
}
8484
});

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/inAppMessages/IInAppMessageClickListener.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ interface IInAppMessageClickListener {
44
/**
55
* Fires when a user clicks on a clickable element in the IAM.
66
*
7-
* @param result The [IInAppMessageClickEvent] with the user's response and properties of this message.
7+
* @param event The [IInAppMessageClickEvent] with the user's response and properties of this message.
88
*/
9-
fun onClick(result: IInAppMessageClickEvent)
9+
fun onClick(event: IInAppMessageClickEvent)
1010
}

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/inAppMessages/InAppMessageActionUrlType.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ enum class InAppMessageActionUrlType(
2424
REPLACE_CONTENT("replacement"),
2525
;
2626

27+
fun toString(): String {
28+
return text
29+
}
30+
2731
companion object {
2832
fun fromString(text: String?): InAppMessageActionUrlType? {
2933
for (type in values()) {

OneSignalSDK/onesignal/in-app-messages/src/main/java/com/onesignal/inAppMessages/internal/InAppMessageClickEvent.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ internal class InAppMessageClickEvent(msg: InAppMessage, actn: InAppMessageClick
1010
get() = _message
1111

1212
override val result: IInAppMessageClickResult
13-
get() = _action
13+
get() = _result
1414

1515
private val _message: InAppMessage = msg
16-
private val _action: InAppMessageClickResult = actn
16+
private val _result: InAppMessageClickResult = actn
1717

1818
fun toJSONObject(): JSONObject {
1919
return JSONObject()
2020
.put("message", _message.toJSONObject())
21-
.put("action", _action.toJSONObject())
21+
.put("action", _result.toJSONObject())
2222
}
2323
}

OneSignalSDK/onesignal/in-app-messages/src/main/java/com/onesignal/inAppMessages/internal/InAppMessageClickResult.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,8 @@ internal class InAppMessageClickResult(json: JSONObject, promptFactory: IInAppMe
111111
if (tags != null) {
112112
mainObj.put(TAGS, tags!!.toJSONObject())
113113
}
114-
// Omitted for now until necessary
115-
// if (urlTarget != null)
116-
// mainObj.put("url_target", urlTarget.toJSONObject());
114+
if (urlTarget != null)
115+
mainObj.put("url_target", urlTarget.toString());
117116
} catch (e: JSONException) {
118117
e.printStackTrace()
119118
}

0 commit comments

Comments
 (0)