Skip to content

Commit a70756a

Browse files
committed
use exact versions in example
Using exact version for dependecies is closer to a real world project and is easier to read.
1 parent 429591b commit a70756a

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

Examples/OneSignalDemo/app/build.gradle

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,22 +54,20 @@ android {
5454

5555
dependencies {
5656
implementation 'com.android.support:multidex:1.0.3'
57-
implementation 'com.google.android.material:material:[1.0.0, 1.4.99]'
57+
implementation 'com.google.android.material:material:1.4.0'
58+
implementation 'androidx.cardview:cardview:1.0.0'
59+
implementation 'androidx.appcompat:appcompat:1.4.0'
60+
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
61+
implementation 'androidx.vectordrawable:vectordrawable:1.1.0'
5862

59-
implementation 'androidx.cardview:cardview:[1.0.0, 1.99.99]'
60-
implementation 'androidx.appcompat:appcompat:[1.0.0, 1.99.99]'
61-
implementation 'androidx.legacy:legacy-support-v4:[1.0.0, 1.99.99]'
62-
implementation 'androidx.vectordrawable:vectordrawable:[1.0.0, 1.99.99]'
63+
implementation 'com.google.android.gms:play-services-location:18.0.0'
64+
65+
implementation 'com.github.bumptech.glide:glide:4.12.0'
6366
// Test public release OneSignal SDK
6467
// This will not work until 4.0.0 is publicly released because of manifest placeholders causing
6568
// manifest merger conflicts
6669
// implementation 'com.onesignal:OneSignal:3.12.6'
6770

68-
implementation 'com.google.android.gms:play-services-location:[17.0.0, 17.99.99]'
69-
// glide:4.9.0 is the last version before going to AndroidX
70-
// glide:4.10.0 is the first version using AndroidX
71-
implementation 'com.github.bumptech.glide:glide:[4.10.0, 4.99.99]'
72-
7371
// Test local OneSignal SDK
7472
gmsImplementation(project(':onesignal'))
7573

0 commit comments

Comments
 (0)