Rename OneSignalCacheCleaner to OSNotificationDataController

* OSNotificationDataController will be the new class responsible for handling notification table access

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSNotificationDataController.java

@@ -0,0 +1,60 @@
+package com.onesignal;
+
+import android.os.Process;
+
+import com.onesignal.OneSignalDbContract.NotificationTable;
+
+class OSNotificationDataController {
+
+    private final static long NOTIFICATION_CACHE_DATA_LIFETIME = 604_800L; // 7 days in second
+
+    private final static String OS_DELETE_CACHED_NOTIFICATIONS_THREAD = "OS_DELETE_CACHED_NOTIFICATIONS_THREAD";
+
+    private final OneSignalDbHelper dbHelper;
+
+    public OSNotificationDataController(OneSignalDbHelper dbHelper) {
+        this.dbHelper = dbHelper;
+    }
+
+    /**
+     * We clean outdated cache from several places within the OneSignal SDK here
+     * 1. Notifications & unique outcome events linked to notification ids (1 week)
+     * 2. Cached In App Messaging Sets in SharedPreferences (impressions, clicks, views) and SQL IAMs
+     */
+    void cleanOldCachedData() {
+        cleanNotificationCache();
+    }
+
+    /**
+     * Cleans two notification tables
+     * 1. NotificationTable.TABLE_NAME
+     * 2. CachedUniqueOutcomeNotificationTable.TABLE_NAME
+     */
+    private void cleanNotificationCache() {
+        new Thread(new Runnable() {
+            @Override
+            public void run() {
+                Thread.currentThread().setPriority(Process.THREAD_PRIORITY_BACKGROUND);
+
+                cleanCachedNotifications(dbHelper);
+            }
+
+        }, OS_DELETE_CACHED_NOTIFICATIONS_THREAD).start();
+    }
+
+    /**
+     * Deletes notifications with created timestamps older than 7 days
+     */
+    private void cleanCachedNotifications(OneSignalDb writableDb) {
+        String whereStr = NotificationTable.COLUMN_NAME_CREATED_TIME + " < ?";
+
+        String sevenDaysAgoInSeconds = String.valueOf((OneSignal.getTime().getCurrentTimeMillis() / 1_000L) - NOTIFICATION_CACHE_DATA_LIFETIME);
+        String[] whereArgs = new String[]{sevenDaysAgoInSeconds};
+
+        writableDb.delete(
+                NotificationTable.TABLE_NAME,
+                whereStr,
+                whereArgs);
+    }
+
+}

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

@@ -31,7 +31,6 @@
 import android.app.AlertDialog;
 import android.app.Application;
 import android.app.NotificationManager;
-import android.app.PendingIntent;
 import android.content.ContentValues;
 import android.content.Context;
 import android.content.Intent;
@@ -433,6 +432,7 @@ static OSInAppMessageController getInAppMessageController() {
    private static OSSessionManager sessionManager = new OSSessionManager(sessionListener, trackerFactory, logger);
    @Nullable private static OSOutcomeEventsController outcomeEventsController;
    @Nullable private static OSOutcomeEventsFactory outcomeEventsFactory;
+   @Nullable private static OSNotificationDataController notificationCache;
 
    @Nullable private static AdvertisingIdentifierProvider adIdProvider;
    private static synchronized @Nullable AdvertisingIdentifierProvider getAdIdProvider() {
@@ -835,17 +835,21 @@ private static void setupContextListeners(boolean wasAppContextNull) {
 
       // Do work here that should only happen once or at the start of a new lifecycle
       if (wasAppContextNull) {
+         // Prefs require a context to save
+         // If the previous state of appContext was null, kick off write in-case it was waiting
+         OneSignalPrefs.startDelayedWrite();
+         notificationCache = new OSNotificationDataController(getDBHelperInstance());
+         // Cleans out old cached data to prevent over using the storage on devices
+         notificationCache.cleanOldCachedData();
+
+         getInAppMessageController().cleanCachedInAppMessages();
+
          if (outcomeEventsFactory == null)
             outcomeEventsFactory = new OSOutcomeEventsFactory(logger, apiClient, getDBHelperInstance(), preferences);
 
          sessionManager.initSessionFromCache();
          outcomeEventsController = new OSOutcomeEventsController(sessionManager, outcomeEventsFactory);
          outcomeEventsController.cleanCachedUniqueOutcomes();
-         // Prefs require a context to save
-         // If the previous state of appContext was null, kick off write in-case it was waiting
-         OneSignalPrefs.startDelayedWrite();
-         // Cleans out old cached data to prevent over using the storage on devices
-         OneSignalCacheCleaner.cleanOldCachedData(appContext);
       }
    }