Skip to content

Commit 950a0a1

Browse files
committed
Fix for unit tests running on travis.
1 parent 34ea6a4 commit 950a0a1

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

OneSignalSDK/app/src/test/java/com/onesignal/ShadowOneSignalRestClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class ShadowOneSignalRestClient {
3737
public static String lastUrl;
3838
public static Thread testThread;
3939
public static boolean failNext, failAll;
40-
public static String failResponse = "{}", nextSuccessResponse;
40+
public static String failResponse = "{}", nextSuccessResponse, nextSuccessfulGETResponse;
4141
public static int networkCallCount;
4242

4343
public static final String testUserId = "a2f7f967-e8cc-11e4-bed1-118f05be4511";
@@ -158,9 +158,9 @@ static void getSync(final String url, final OneSignalRestClient.ResponseHandler
158158
doInterruptibleDelay();
159159
if (doFail(responseHandler)) return;
160160

161-
if (nextSuccessResponse != null) {
162-
responseHandler.onSuccess(nextSuccessResponse);
163-
nextSuccessResponse = null;
161+
if (nextSuccessfulGETResponse != null) {
162+
responseHandler.onSuccess(nextSuccessfulGETResponse);
163+
nextSuccessfulGETResponse = null;
164164
}
165165
else
166166
responseHandler.onSuccess("{}");

OneSignalSDK/app/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ public void shouldGetTagsFromServerOnFirstCall() throws Exception {
981981
OneSignalInit();
982982
threadAndTaskWait();
983983

984-
ShadowOneSignalRestClient.nextSuccessResponse = "{\"tags\": {\"test1\": \"value1\", \"test2\": \"value2\"}}";
984+
ShadowOneSignalRestClient.nextSuccessfulGETResponse = "{\"tags\": {\"test1\": \"value1\", \"test2\": \"value2\"}}";
985985
GetTags();
986986
threadAndTaskWait(); threadAndTaskWait();
987987

@@ -996,11 +996,11 @@ public void shouldGetTagsFromServerOnFirstCall() throws Exception {
996996

997997
@Test
998998
public void getTagsDelayedAfterRegistering() throws Exception {
999+
ShadowOneSignalRestClient.nextSuccessfulGETResponse = "{\"tags\": {\"test1\": \"value1\"}}";
1000+
9991001
OneSignalInit();
10001002
GetTags();
1001-
threadAndTaskWait();
1002-
ShadowOneSignalRestClient.nextSuccessResponse = "{\"tags\": {\"test1\": \"value1\"}}";
1003-
threadAndTaskWait(); threadAndTaskWait();
1003+
threadAndTaskWait(); threadAndTaskWait(); threadAndTaskWait();
10041004

10051005
Assert.assertEquals(3, ShadowOneSignalRestClient.networkCallCount);
10061006
Assert.assertEquals("value1", lastGetTags.getString("test1"));

0 commit comments

Comments
 (0)