Channel payload boolean to integer format change

Author: jkasten2

OneSignalSDK/onesignal/src/main/java/com/onesignal/NotificationChannelManager.java

@@ -122,13 +122,13 @@ private static String createChannel(Context context, NotificationManager notific
          channel.setGroup(group_id);
       }
 
-      channel.enableLights(payload.optBoolean("led", true));
+      channel.enableLights(payload.optInt("led", 1) == 1);
       if (payload.has("ledc")) {
          BigInteger ledColor = new BigInteger(payload.optString("ledc"), 16);
          channel.setLightColor(ledColor.intValue());
       }
 
-      channel.enableVibration(payload.optBoolean("vib", true));
+      channel.enableVibration(payload.optInt("vib", 1) == 1);
       if (payload.has("vib_pt")) {
          JSONArray json_vib_array = payload.optJSONArray("vib_pt");
          long[] long_array = new long[json_vib_array.length()];
@@ -151,8 +151,8 @@ else if ("null".equals(sound) || "nil".equals(sound))
       // Otherwise not calling setSound makes it the default notification sound.
 
       channel.setLockscreenVisibility(payload.optInt("vis", Notification.VISIBILITY_PUBLIC));
-      channel.setShowBadge(payload.optBoolean("bdg", true));
-      channel.setBypassDnd(payload.optBoolean("bdnd", false));
+      channel.setShowBadge(payload.optInt("bdg", 1) == 1);
+      channel.setBypassDnd(payload.optInt("bdnd", 0) == 1);
 
       notificationManager.createNotificationChannel(channel);
       return channel_id;

OneSignalSDK/unittest/build.gradle

@@ -78,5 +78,5 @@ dependencies {
     compile 'com.android.support:customtabs:26.0.0'
 
     testCompile 'junit:junit:4.12'
-    testCompile 'org.robolectric:robolectric:3.4'
+    testCompile 'org.robolectric:robolectric:3.4.2'
 }

OneSignalSDK/unittest/src/test/java/com/test/onesignal/NotificationChannelManagerRunner.java

@@ -105,14 +105,14 @@ public void createNotificationChannelWithALlOptions() throws Exception {
       chnl.put("grp_nm", "Group Name");
 
       payload.put("pri", 10);
-      payload.put("led", false);
+      payload.put("led", 0);
       payload.put("ledc", "FFFF0000");
-      payload.put("vib", false);
+      payload.put("vib", 0);
       payload.put("vib_pt", new JSONArray("[1,2,3,4]"));
       payload.put("sound", "notification");
       payload.put("vis", Notification.VISIBILITY_SECRET);
-      payload.put("bdg", true);
-      payload.put("bdnd", true);
+      payload.put("bdg", 1);
+      payload.put("bdnd", 1);
 
       payload.put("chnl", chnl);