Skip to content

Commit 8f41976

Browse files
committed
Fixed static values getting into release .aar file
1 parent a51354d commit 8f41976

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

OneSignalSDK/onesignal/build.gradle

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,13 @@ apply plugin: 'com.android.library'
33
android {
44
compileSdkVersion 28
55
defaultConfig {
6-
manifestPlaceholders = [onesignal_app_id: 'b2f7f966-d8cc-11e4-bed1-df8f05be55ba',
6+
// Normally we shouldn't need to redefine manifestPlaceholders for our onesignal project
7+
// but Android Studio gets a sync error if these are not here.
8+
// - /gradlew onesignal:assembleRelease is fine from the console.
9+
// We can't use static values are these are directly added to the AndroidManifest.xml in the .aar file.
10+
manifestPlaceholders = [onesignal_app_id: '${onesignal_app_id}',
711
// Project number pulled from dashboard, local value is ignored
8-
onesignal_google_project_number: 'REMOTE']
12+
onesignal_google_project_number: '${onesignal_google_project_number}']
913
minSdkVersion 15
1014
consumerProguardFiles 'consumer-proguard-rules.pro'
1115
}

0 commit comments

Comments
 (0)