add test for getTags

Got rid of userManager.tags getter because it conflicts the name generated by the JVM which is also getTags

Author: jinliu9508

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/UserManager.kt

@@ -23,9 +23,6 @@ internal open class UserManager(
     val externalId: String?
         get() = _identityModel.externalId
 
-    val tags: Map<String, String>
-        get() = _propertiesModel.tags
-
     val aliases: Map<String, String>
         get() = _identityModel.filter { it.key != IdentityModel::id.name }.toMap()
 

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/user/internal/UserManagerTests.kt

@@ -107,8 +107,8 @@ class UserManagerTests : FunSpec({
             UserManager(mockSubscriptionManager, MockHelper.identityModelStore(), propertiesModelStore, MockHelper.languageContext())
 
         // When
-        val tag1 = userManager.tags["my-tag-key1"]
-        val tag2 = userManager.tags["my-tag-key2"]
+        val tag1 = propertiesModelStore.model.tags["my-tag-key1"]
+        val tag2 = propertiesModelStore.model.tags["my-tag-key2"]
 
         // add
         userManager.addTag("my-tag-key5", "my-tag-value5")
@@ -135,6 +135,25 @@ class UserManagerTests : FunSpec({
         propertiesModelStore.model.tags["my-tag-key3"] shouldBe null
     }
 
+    test("getTags returns a copy of tags") {
+        // Given
+        val mockSubscriptionManager = mockk<ISubscriptionManager>()
+        val propertiesModelStore =
+                MockHelper.propertiesModelStore {
+                    it.tags["my-tag-key1"] = "my-tag-value1"
+                }
+
+        val userManager =
+                UserManager(mockSubscriptionManager, MockHelper.identityModelStore(), propertiesModelStore, MockHelper.languageContext())
+
+        // When
+        val allTags = userManager.getTags()
+
+        // Then
+        allTags.size shouldBe propertiesModelStore.model.tags.size
+        allTags["my-tag-key1"] shouldBe propertiesModelStore.model.tags["my-tag-key1"]
+    }
+
     test("subscriptions are backed by the subscriptions manager") {
         // Given
         val subscriptionList = SubscriptionList(listOf(), UninitializedPushSubscription())