Skip to content

Commit 821bbfe

Browse files
committed
rm onesignal-gradle-plugin so substitution works
The onesignal-gradle-plugin currently breaks the Gradle `dependencySubstitution` feature we introduced in the last commit so we removed it from the example project. Adding`googleServices { disableVersionCheck = true }` was required since the `onesignal-gradle-plugin` auto disables this part of the `com.google.gms.google-services` for us. The current OneSignal-Android-SDK doesn't work with it since it uses version ranges which is a re-existing issue.
1 parent 7cb718c commit 821bbfe

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Examples/OneSignalDemo/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'
21
apply plugin: 'com.android.application'
32

43
android {
@@ -46,6 +45,7 @@ android {
4645
task flavorSelection() {
4746
if (getGradle().getStartParameter().getTaskRequests().toString().contains("Gms")) {
4847
apply plugin: 'com.google.gms.google-services'
48+
googleServices { disableVersionCheck = true }
4949
} else {
5050
apply plugin: 'com.huawei.agconnect'
5151
}

0 commit comments

Comments
 (0)