Update external id method

* Implement method from demo app
* Rename from onComplete to onSuccess

Author: Jeasmine

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/util/Dialog.java

@@ -183,7 +183,7 @@ public void run() {
             private void updateExternalUserId(final DialogInterface dialog, final String externalUserId) {
                 OneSignal.setExternalUserId(externalUserId, new OneSignal.OSExternalUserIdUpdateCompletionHandler() {
                     @Override
-                    public void onComplete(JSONObject results) {
+                    public void onSuccess(JSONObject results) {
                         // Default success to false until we know push came back successful
                         boolean successful = false;
 
@@ -210,6 +210,13 @@ public void onComplete(JSONObject results) {
                         dialog.dismiss();
                     }
 
+                    @Override
+                    public void onFailure(OneSignal.ExternalIdError error) {
+                        OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "External user id set failed with error: " + error);
+                        callback.onFailure();
+                        dialog.dismiss();
+                    }
+
                     /**
                      * Parse the results of the external user id completion callback and make sure push.success = true
                      */

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

@@ -253,7 +253,7 @@ public String getMessage() {
    }
 
    public interface OSExternalUserIdUpdateCompletionHandler {
-      void onComplete(JSONObject results);
+      void onSuccess(JSONObject results);
       void onFailure(ExternalIdError error);
    }
 

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignalStateSynchronizer.java

@@ -216,7 +216,7 @@ public void onComplete(String channel, boolean success) {
                @Override
                public void run() {
                   if (completionHandler != null)
-                     completionHandler.onComplete(responses);
+                     completionHandler.onSuccess(responses);
                }
             });
          }

OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

@@ -219,7 +219,7 @@ private static OneSignal.OSNotificationOpenedHandler getNotificationOpenedHandle
    private static OneSignal.OSExternalUserIdUpdateCompletionHandler getExternalUserIdUpdateCompletionHandler() {
       return new OneSignal.OSExternalUserIdUpdateCompletionHandler() {
          @Override
-         public void onComplete(JSONObject results) {
+         public void onSuccess(JSONObject results) {
             lastExternalUserIdResponse = results;
          }