add a test unit and fix some bugs

Author: jinliu9508

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/operations/impl/OperationRepo.kt

@@ -58,11 +58,11 @@ internal class OperationRepo(
         get() = loadedSubscription.hasSubscribers
 
     override fun unsubscribe(handler: IOperationRepoLoadedListener) {
-        loadedSubscription.subscribe(handler)
+        loadedSubscription.unsubscribe(handler)
     }
 
     override fun subscribe(handler: IOperationRepoLoadedListener) {
-        loadedSubscription.unsubscribe(handler)
+        loadedSubscription.subscribe(handler)
     }
 
     /** *** Buckets ***

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/core/internal/operations/OperationRepoTests.kt

@@ -9,9 +9,6 @@ import com.onesignal.core.internal.time.impl.Time
 import com.onesignal.debug.LogLevel
 import com.onesignal.debug.internal.logging.Logging
 import com.onesignal.mocks.MockHelper
-import com.onesignal.user.internal.identity.IdentityModel
-import com.onesignal.user.internal.identity.IdentityModelStore
-import com.onesignal.user.internal.migrations.RecoverFromDroppedLoginBug
 import com.onesignal.user.internal.operations.ExecutorMocks.Companion.getNewRecordState
 import io.kotest.core.spec.style.FunSpec
 import io.kotest.matchers.shouldBe
@@ -594,17 +591,21 @@ class OperationRepoTests : FunSpec({
         result shouldBe null
     }
 
-    test("IOperationRepoLoadedListener") {
+    test("ensure onOperationRepoLoaded is called once loading is completed") {
+        // Given
         val mocks = Mocks()
-        val mockIdentityModel = mockk<IdentityModel>()
-        val mockIdentityModelStore = mockk<IdentityModelStore>()
-        val recovery = RecoverFromDroppedLoginBug(mocks.operationRepo, mockIdentityModelStore, mocks.configModelStore)
+        val spyListener = spyk<IOperationRepoLoadedListener>()
 
+        // When
+        mocks.operationRepo.addOperationLoadedListener(spyListener)
         mocks.operationRepo.start()
-        recovery.start()
 
-        verify {
-            mocks.operationRepo.subscribe(recovery)
+        // Then
+        mocks.operationRepo.hasSubscribers shouldBe true
+        coVerifyOrder {
+            mocks.operationRepo.subscribe(any())
+            mocks.operationModelStore.loadOperations()
+            spyListener.onOperationRepoLoaded()
         }
     }
 }) {

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/user/internal/migrations/RecoverFromDroppedLoginBugTests.kt

@@ -0,0 +1,48 @@
+package com.onesignal.user.internal.migrations
+
+import com.onesignal.core.internal.config.ConfigModelStore
+import com.onesignal.core.internal.operations.impl.OperationModelStore
+import com.onesignal.core.internal.operations.impl.OperationRepo
+import com.onesignal.core.internal.time.impl.Time
+import com.onesignal.mocks.MockHelper
+import com.onesignal.user.internal.operations.ExecutorMocks
+import io.kotest.core.spec.style.FunSpec
+import io.mockk.every
+import io.mockk.just
+import io.mockk.mockk
+import io.mockk.runs
+import io.mockk.spyk
+import io.mockk.verify
+
+class RecoverFromDroppedLoginBugTests : FunSpec({
+    test("ensure RecoverFromDroppedLoginBug receive onOperationRepoLoaded callback from operationRepo") {
+        // Given
+        val mockOperationModelStore = mockk<OperationModelStore>()
+        val mockConfigModelStore = mockk<ConfigModelStore>()
+        val operationRepo =
+            spyk(
+                OperationRepo(
+                    listOf(),
+                    mockOperationModelStore,
+                    mockConfigModelStore,
+                    Time(),
+                    ExecutorMocks.getNewRecordState(mockConfigModelStore),
+                ),
+            )
+        every { mockOperationModelStore.loadOperations() } just runs
+        every { mockOperationModelStore.list() } returns listOf()
+
+        val recovery = RecoverFromDroppedLoginBug(operationRepo, MockHelper.identityModelStore(), mockConfigModelStore)
+        every { recovery.onOperationRepoLoaded() } just runs
+
+        // When
+        operationRepo.start()
+        recovery.start()
+
+        // Then
+        verify {
+            operationRepo.subscribe(recovery)
+            recovery.onOperationRepoLoaded()
+        }
+    }
+})