Update core module property naming

address linting error that enforces camel case/screaming snake case & disallows backticks

Author: jennantilla

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/IOneSignal.kt

@@ -23,38 +23,38 @@ interface IOneSignal {
      * The user manager for accessing user-scoped
      * management.
      */
-    val User: IUserManager
+    val user: IUserManager
 
     /**
      * The session manager for accessing session-scoped management.
      */
-    val Session: ISessionManager
+    val session: ISessionManager
 
     /**
      * The notification manager for accessing device-scoped
      * notification management.
      */
-    val Notifications: INotificationsManager
+    val notifications: INotificationsManager
 
     /**
      * The location manager for accessing device-scoped
      * location management.
      */
-    val Location: ILocationManager
+    val location: ILocationManager
 
     /**
      * The In App Messaging manager for accessing device-scoped
      * IAP management.
      */
-    val InAppMessages: IInAppMessagesManager
+    val inAppMessages: IInAppMessagesManager
 
     /**
      * Access to debug the SDK in the event additional information is required to diagnose any
      * SDK-related issues.
      *
      * WARNING: This should not be used in a production setting.
      */
-    val Debug: IDebugManager
+    val debug: IDebugManager
 
     /**
      * Determines whether a user must consent to privacy prior
@@ -90,7 +90,7 @@ interface IOneSignal {
 
     /**
      * Login to OneSignal under the user identified by the [externalId] provided. The act of
-     * logging a user into the OneSignal SDK will switch the [User] context to that specific user.
+     * logging a user into the OneSignal SDK will switch the [user] context to that specific user.
      *
      * * If the [externalId] exists the user will be retrieved and the context set from that
      *   user information. If operations have already been performed under a guest user, they
@@ -117,7 +117,7 @@ interface IOneSignal {
     fun login(externalId: String) = login(externalId, null)
 
     /**
-     * Logout the user previously logged in via [login]. The [User] property now references
+     * Logout the user previously logged in via [login]. The [user] property now references
      * a new device-scoped user. A device-scoped user has no user identity that can later
      * be retrieved, except through this device as long as the app remains installed and the app
      * data is not cleared.

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/OneSignal.kt

@@ -43,39 +43,39 @@ object OneSignal {
      */
     @JvmStatic
     val User: IUserManager
-        get() = oneSignal.User
+        get() = oneSignal.user
 
     /**
      * The session manager for accessing session-scoped management.  Initialized only after [initWithContext]
      * has been called.
      */
     @JvmStatic
     val Session: ISessionManager
-        get() = oneSignal.Session
+        get() = oneSignal.session
 
     /**
      * The notification manager for accessing device-scoped notification management. Initialized
      * only after [initWithContext] has been called.
      */
     @JvmStatic
     val Notifications: INotificationsManager
-        get() = oneSignal.Notifications
+        get() = oneSignal.notifications
 
     /**
      * The location manager for accessing device-scoped location management. Initialized
      * only after [initWithContext] has been called.
      */
     @JvmStatic
     val Location: ILocationManager
-        get() = oneSignal.Location
+        get() = oneSignal.location
 
     /**
      * The In App Messaging manager for accessing device-scoped IAP management. Initialized
      * only after [initWithContext] has been called.
      */
     @JvmStatic
     val InAppMessages: IInAppMessagesManager
-        get() = oneSignal.InAppMessages
+        get() = oneSignal.inAppMessages
 
     /**
      * Access to debug the SDK in the additional information is required to diagnose any
@@ -85,7 +85,7 @@ object OneSignal {
      */
     @JvmStatic
     val Debug: IDebugManager
-        get() = oneSignal.Debug
+        get() = oneSignal.debug
 
     /**
      * Determines whether a user must consent to privacy prior

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/NetworkUtils.kt

@@ -9,7 +9,7 @@ object NetworkUtils {
         CONFLICT,
     }
 
-    var MAX_NETWORK_REQUEST_ATTEMPT_COUNT = 3
+    var maxNetworkRequestAttemptCount = 3
 
     fun getResponseStatusType(statusCode: Int): ResponseStatusType {
         return when (statusCode) {

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/OneSignalUtils.kt

@@ -6,7 +6,7 @@ object OneSignalUtils {
     /**
      * The version of this SDK.
      */
-    const val sdkVersion: String = "050003"
+    const val SDK_VERSION: String = "050003"
 
     fun isValidEmail(email: String): Boolean {
         if (email.isEmpty()) {

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/events/CallbackProducer.kt

@@ -9,13 +9,13 @@ import kotlinx.coroutines.withContext
  * make callbacks less burdensome to the user.
  */
 open class CallbackProducer<THandler>() : ICallbackNotifier<THandler> {
-    private var _callback: THandler? = null
+    private var callback: THandler? = null
 
     override val hasCallback: Boolean
-        get() = _callback != null
+        get() = callback != null
 
     override fun set(handler: THandler?) {
-        _callback = handler
+        callback = handler
     }
 
     /**
@@ -26,8 +26,8 @@ open class CallbackProducer<THandler>() : ICallbackNotifier<THandler> {
      * @param callback The callback will be invoked if one exists, allowing you to call the handler.
      */
     fun fire(callback: (THandler) -> Unit) {
-        if (_callback != null) {
-            callback(_callback!!)
+        if (this.callback != null) {
+            callback(this.callback!!)
         }
     }
 
@@ -42,8 +42,8 @@ open class CallbackProducer<THandler>() : ICallbackNotifier<THandler> {
      */
     fun fireOnMain(callback: (THandler) -> Unit) {
         suspendifyOnMain {
-            if (_callback != null) {
-                callback(_callback!!)
+            if (this.callback != null) {
+                callback(this.callback!!)
             }
         }
     }
@@ -56,8 +56,8 @@ open class CallbackProducer<THandler>() : ICallbackNotifier<THandler> {
      * @param callback The callback will be invoked if one exists, allowing you to call the handler.
      */
     suspend fun suspendingFire(callback: suspend (THandler) -> Unit) {
-        if (_callback != null) {
-            callback(_callback!!)
+        if (this.callback != null) {
+            callback(this.callback!!)
         }
     }
 
@@ -70,9 +70,9 @@ open class CallbackProducer<THandler>() : ICallbackNotifier<THandler> {
      * @param callback The callback will be invoked if one exists, allowing you to call the handler.
      */
     suspend fun suspendingFireOnMain(callback: suspend (THandler) -> Unit) {
-        if (_callback != null) {
+        if (this.callback != null) {
             withContext(Dispatchers.Main) {
-                callback(_callback!!)
+                callback(this@CallbackProducer.callback!!)
             }
         }
     }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/events/EventProducer.kt

@@ -11,23 +11,23 @@ import java.util.Collections
  */
 open class EventProducer<THandler> : IEventNotifier<THandler> {
     override val hasSubscribers: Boolean
-        get() = _subscribers.any()
+        get() = subscribers.any()
 
-    private val _subscribers: MutableList<THandler> = Collections.synchronizedList(mutableListOf())
+    private val subscribers: MutableList<THandler> = Collections.synchronizedList(mutableListOf())
 
     override fun subscribe(handler: THandler) {
-        _subscribers.add(handler)
+        subscribers.add(handler)
     }
 
     override fun unsubscribe(handler: THandler) {
-        _subscribers.remove(handler)
+        subscribers.remove(handler)
     }
 
     /**
      * Subscribe all from an existing producer to this subscriber.
      */
     fun subscribeAll(from: EventProducer<THandler>) {
-        for (s in from._subscribers) {
+        for (s in from.subscribers) {
             subscribe(s)
         }
     }
@@ -39,7 +39,7 @@ open class EventProducer<THandler> : IEventNotifier<THandler> {
      * @param callback The callback will be invoked for each subscribed handler, allowing you to call the handler.
      */
     fun fire(callback: (THandler) -> Unit) {
-        for (s in _subscribers) {
+        for (s in subscribers) {
             callback(s)
         }
     }
@@ -53,7 +53,7 @@ open class EventProducer<THandler> : IEventNotifier<THandler> {
      */
     fun fireOnMain(callback: (THandler) -> Unit) {
         suspendifyOnMain {
-            for (s in _subscribers) {
+            for (s in subscribers) {
                 callback(s)
             }
         }
@@ -66,7 +66,7 @@ open class EventProducer<THandler> : IEventNotifier<THandler> {
      * @param callback The callback will be invoked for each subscribed handler, allowing you to call the handler.
      */
     suspend fun suspendingFire(callback: suspend (THandler) -> Unit) {
-        for (s in _subscribers) {
+        for (s in subscribers) {
             callback(s)
         }
     }
@@ -79,7 +79,7 @@ open class EventProducer<THandler> : IEventNotifier<THandler> {
      */
     suspend fun suspendingFireOnMain(callback: suspend (THandler) -> Unit) {
         withContext(Dispatchers.Main) {
-            for (s in _subscribers) {
+            for (s in subscribers) {
                 callback(s)
             }
         }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/modeling/Model.kt

@@ -62,7 +62,7 @@ open class Model(
         }
 
     protected val data: MutableMap<String, Any?> = Collections.synchronizedMap(mutableMapOf())
-    private val _changeNotifier = EventProducer<IModelChangedHandler>()
+    private val changeNotifier = EventProducer<IModelChangedHandler>()
 
     init {
         if (_parentModel != null && _parentProperty == null) {
@@ -644,7 +644,7 @@ open class Model(
     ) {
         // if there are any changed listeners for this specific model, notify them.
         val changeArgs = ModelChangedArgs(this, path, property, oldValue, newValue)
-        _changeNotifier.fire { it.onChanged(changeArgs, tag) }
+        changeNotifier.fire { it.onChanged(changeArgs, tag) }
 
         // if there is a parent model, propagate the change up to the parent for it's own processing.
         if (_parentModel != null) {
@@ -684,10 +684,10 @@ open class Model(
         return jsonObject
     }
 
-    override fun subscribe(handler: IModelChangedHandler) = _changeNotifier.subscribe(handler)
+    override fun subscribe(handler: IModelChangedHandler) = changeNotifier.subscribe(handler)
 
-    override fun unsubscribe(handler: IModelChangedHandler) = _changeNotifier.unsubscribe(handler)
+    override fun unsubscribe(handler: IModelChangedHandler) = changeNotifier.unsubscribe(handler)
 
     override val hasSubscribers: Boolean
-        get() = _changeNotifier.hasSubscribers
+        get() = changeNotifier.hasSubscribers
 }