You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #1794 made changes to omit aliases on user create, but the test was
never updated. Also the SubscriptionStatus arg part of this test wasn't
compare the corret types, causing it to fail the test.
Copy file name to clipboardExpand all lines: OneSignalSDK/onesignal/core/src/test/java/com/onesignal/user/internal/operations/LoginUserOperationExecutorTests.kt
+10-5Lines changed: 10 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -392,13 +392,18 @@ class LoginUserOperationExecutorTests : FunSpec({
392
392
coVerify(exactly = 1) {
393
393
mockUserBackendService.createUser(
394
394
appId,
395
-
mapOf("aliasLabel1" to "aliasValue1-2"),
395
+
// Aliases omitted intentionally in PR #1794, to avoid failed create user calls.
396
+
// - Ideally we batch as much as possible into the create as most of the time it
397
+
// should be successful. Then when there are failures omit the "bad data" and try
398
+
// again, however this is more complex which is why it wasn't done initially.
0 commit comments