Skip to content

Commit 698b14f

Browse files
authored
Merge pull request #1678 from OneSignal/user-model/gradle-modularization
[User Model] Modularize IAM/Notification/Location
2 parents a0b4a74 + 5e9019e commit 698b14f

File tree

425 files changed

+2166
-1744
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

425 files changed

+2166
-1744
lines changed

Examples/OneSignalDemo/app/build.gradle

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
apply plugin: 'com.android.application'
1+
plugins {
2+
id 'com.android.application'
3+
}
24

35
android {
4-
compileSdkVersion 31
6+
compileSdkVersion 33
57
defaultConfig {
68
minSdkVersion 16
7-
targetSdkVersion 31
9+
targetSdkVersion 33
810
versionCode 1
911
versionName "1.0"
1012
multiDexEnabled true
@@ -54,24 +56,28 @@ android {
5456

5557
dependencies {
5658
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlinVersion"
57-
implementation 'com.android.support:multidex:1.0.3'
58-
implementation 'com.google.android.material:material:1.4.0'
59+
implementation 'androidx.multidex:multidex:2.0.1'
5960
implementation 'androidx.cardview:cardview:1.0.0'
60-
implementation 'androidx.appcompat:appcompat:1.4.0'
61+
implementation 'androidx.appcompat:appcompat:1.5.1'
6162
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
6263
implementation 'androidx.vectordrawable:vectordrawable:1.1.0'
6364

64-
implementation 'com.google.android.gms:play-services-location:18.0.0'
65+
implementation 'com.google.android.material:material:1.7.0'
66+
implementation 'com.google.android.gms:play-services-location:21.0.0'
6567

6668
implementation 'com.github.bumptech.glide:glide:4.12.0'
6769

70+
implementation('com.onesignal:OneSignal:4.8.2')
71+
implementation('com.onesignal:Location:4.8.2')
72+
implementation('com.onesignal:IAM:4.8.2')
73+
6874
/** START - Google Play Builds **/
69-
gmsImplementation('com.onesignal:OneSignal:4.6.3')
75+
gmsImplementation('com.onesignal:Notification:4.8.2')
7076
/** END - Google Play Builds **/
7177

7278
/** START - Huawei Builds **/
7379
// Omit Google / Firebase libraries for Huawei builds.
74-
huaweiImplementation('com.onesignal:OneSignal:4.6.3') {
80+
huaweiImplementation('com.onesignal:Notification:4.8.2') {
7581
exclude group: 'com.google.android.gms', module: 'play-services-gcm'
7682
exclude group: 'com.google.android.gms', module: 'play-services-analytics'
7783
exclude group: 'com.google.android.gms', module: 'play-services-location'

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/activity/MainActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import androidx.annotation.RequiresApi;
77
import androidx.appcompat.app.AppCompatActivity;
88

9-
import com.onesignal.core.OneSignal;
9+
import com.onesignal.OneSignal;
1010
import com.onesignal.sdktest.R;
1111
import com.onesignal.sdktest.model.MainActivityViewModel;
1212

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
import androidx.annotation.Nullable;
88
import androidx.multidex.MultiDexApplication;
99

10-
import com.onesignal.core.OneSignal;
10+
import com.onesignal.OneSignal;
1111
import com.onesignal.iam.IInAppMessage;
1212
import com.onesignal.iam.IInAppMessageAction;
1313
import com.onesignal.iam.IInAppMessageClickHandler;
1414
import com.onesignal.iam.IInAppMessageLifecycleHandler;
15-
import com.onesignal.core.debug.LogLevel;
15+
import com.onesignal.debug.LogLevel;
1616
import com.onesignal.notification.INotification;
1717
import com.onesignal.sdktest.BuildConfig;
1818
import com.onesignal.sdktest.R;

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/model/MainActivityViewModel.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424
import android.widget.Switch;
2525
import android.widget.TextView;
2626

27-
import com.onesignal.core.Continue;
28-
import com.onesignal.core.OneSignal;
27+
import com.onesignal.Continue;
28+
import com.onesignal.OneSignal;
2929
import com.onesignal.notification.IPermissionStateChanges;
30-
import com.onesignal.core.user.subscriptions.IEmailSubscription;
31-
import com.onesignal.core.user.subscriptions.IPushSubscription;
32-
import com.onesignal.core.user.subscriptions.ISmsSubscription;
30+
import com.onesignal.user.subscriptions.IEmailSubscription;
31+
import com.onesignal.user.subscriptions.IPushSubscription;
32+
import com.onesignal.user.subscriptions.ISmsSubscription;
3333
import com.onesignal.sdktest.R;
3434
import com.onesignal.sdktest.activity.SecondaryActivity;
3535
import com.onesignal.sdktest.adapter.InAppMessageRecyclerViewAdapter;

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/model/SplashActivityViewModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import androidx.annotation.Nullable;
99
import androidx.appcompat.app.AppCompatActivity;
1010

11-
import com.onesignal.core.OneSignal;
11+
import com.onesignal.OneSignal;
1212
import com.onesignal.notification.IPermissionStateChanges;
1313
import com.onesignal.sdktest.constant.Tag;
1414
import com.onesignal.sdktest.constant.Text;

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/notification/NotificationServiceExtension.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
import android.content.Context;
44

5-
import com.onesignal.core.debug.LogLevel;
6-
import com.onesignal.core.internal.logging.Logging;
5+
import com.onesignal.debug.LogLevel;
6+
import com.onesignal.debug.internal.logging.Logging;
77
import com.onesignal.notification.IActionButton;
88
import com.onesignal.notification.IMutableNotification;
99
import com.onesignal.notification.INotification;

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/notification/OneSignalNotificationSender.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import android.util.Log;
44

5-
import com.onesignal.core.Continue;
6-
import com.onesignal.core.OneSignal;
7-
import com.onesignal.core.user.subscriptions.IPushSubscription;
5+
import com.onesignal.Continue;
6+
import com.onesignal.OneSignal;
7+
import com.onesignal.user.subscriptions.IPushSubscription;
88
import com.onesignal.sdktest.constant.Tag;
99
import com.onesignal.sdktest.type.Notification;
1010

OneSignalSDK/build.gradle

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,19 @@ buildscript {
55
ext {
66
buildVersions = [
77
compileSdkVersion: 31,
8-
targetSdkVersion: 31
8+
targetSdkVersion: 31,
9+
minSdkVersion: 16
910
]
10-
androidGradlePluginVersion = '7.0.4'
11+
androidGradlePluginVersion = '7.2.0'
1112
googleServicesGradlePluginVersion = '4.3.10'
1213
huaweiAgconnectVersion = '1.6.2.300'
1314
huaweiHMSPushVersion = '6.3.0.304'
1415
huaweiHMSLocationVersion = '4.0.0.300'
15-
kotlinVersion = '1.6.21'
16+
kotlinVersion = '1.7.10'
1617
kotestVersion = '5.5.0'
1718
ktlintVersion = '11.0.0'
1819
detektVersion = '1.21.0'
20+
junitVersion = '4.13.2'
1921
}
2022

2123
repositories {
@@ -30,7 +32,6 @@ buildscript {
3032
classpath "com.google.gms:google-services:$googleServicesGradlePluginVersion"
3133
classpath "com.huawei.agconnect:agcp:$huaweiAgconnectVersion"
3234
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
33-
3435
classpath "org.jlleitschuh.gradle:ktlint-gradle:$ktlintVersion"
3536
classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:$detektVersion"
3637
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.1-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

OneSignalSDK/onesignal/build.gradle

Lines changed: 14 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,16 @@
1-
ext {
2-
buildVersions = [
3-
minSdkVersion: 16
4-
]
1+
plugins {
2+
id 'com.android.library'
3+
id 'kotlin-android'
4+
id 'org.jlleitschuh.gradle.ktlint'
5+
id 'io.gitlab.arturbosch.detekt'
56
}
67

7-
apply plugin: 'com.android.library'
8-
apply plugin: 'kotlin-android'
9-
apply plugin: 'kotlin-android-extensions'
10-
apply plugin: 'org.jlleitschuh.gradle.ktlint'
11-
apply plugin: 'io.gitlab.arturbosch.detekt'
12-
138
android {
149
compileSdkVersion rootProject.buildVersions.compileSdkVersion
1510
defaultConfig {
16-
minSdkVersion buildVersions.minSdkVersion
17-
consumerProguardFiles 'consumer-proguard-rules.pro'
11+
minSdkVersion rootProject.buildVersions.minSdkVersion
12+
consumerProguardFiles 'consumer-rules.pro'
1813
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
19-
testOptions.unitTests.includeAndroidResources = true
2014
}
2115

2216
buildTypes {
@@ -45,6 +39,10 @@ android {
4539
sourceCompatibility JavaVersion.VERSION_1_8
4640
targetCompatibility JavaVersion.VERSION_1_8
4741
}
42+
kotlinOptions {
43+
jvmTarget = '1.8'
44+
}
45+
namespace 'com.onesignal'
4846
}
4947

5048
tasks.withType(Test) {
@@ -62,79 +60,26 @@ tasks.withType(Test) {
6260
// make sure the latest minor value is a known stable version. Using a range for the
6361
// patch version is ok, since this allows getting bug fix versions.
6462
dependencies {
65-
compileOnly fileTree(dir: 'libs', include: ['*.jar'])
66-
compileOnly('com.amazon.device:amazon-appstore-sdk:[3.0.1, 3.0.99]')
67-
6863
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlinVersion"
6964
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4"
7065
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4"
71-
implementation 'androidx.work:work-runtime-ktx:2.7.1'
72-
73-
// play-services-location:16.0.0 is the last version before going to AndroidX
74-
// play-services-location:17.0.0 is the first version using AndroidX
75-
compileOnly('com.google.android.gms:play-services-location:[17.0.0, 18.0.99]') {
76-
version {
77-
require '[17.0.0, 18.0.99]'
78-
prefer '18.0.0'
79-
}
80-
}
8166

82-
// play-services-base:16.1.0 is the last version before going to AndroidX
83-
// play-services-base:17.0.0 is the first version using AndroidX
84-
// Required for GoogleApiAvailability
85-
implementation('com.google.android.gms:play-services-base') {
86-
version {
87-
require '[17.0.0, 17.6.99]'
88-
prefer '17.6.0'
89-
}
90-
}
91-
92-
// firebase-messaging:18.0.0 is the last version before going to AndroidX
93-
// firebase-messaging:19.0.0 is the first version using AndroidX
94-
api('com.google.firebase:firebase-messaging') {
95-
version {
96-
require '[19.0.0, 22.0.99]'
97-
prefer '22.0.0'
98-
}
99-
}
100-
101-
// Huawei PushKit
102-
// KEEP as "compileOnly", so OneSignal isn't a direct dependency in the POM file.
103-
compileOnly "com.huawei.hms:push:$huaweiHMSPushVersion"
104-
compileOnly "com.huawei.hms:location:$huaweiHMSLocationVersion"
67+
compileOnly('com.amazon.device:amazon-appstore-sdk:[3.0.1, 3.0.99]')
10568

106-
api('androidx.cardview:cardview') {
107-
version {
108-
require '[1.0.0, 1.0.99]'
109-
prefer '1.0.0'
110-
}
111-
}
11269
api('androidx.legacy:legacy-support-v4') {
11370
version {
11471
require '[1.0.0, 1.0.99]'
11572
prefer '1.0.0'
11673
}
11774
}
118-
api('androidx.browser:browser') {
119-
version {
120-
require '[1.0.0, 1.3.99]'
121-
prefer '1.3.0'
122-
}
123-
}
12475
api('androidx.appcompat:appcompat') {
12576
version {
12677
require '[1.0.0, 1.3.99]'
12778
prefer '1.3.1'
12879
}
12980
}
130-
api('androidx.work:work-runtime') {
131-
version {
132-
require '[2.1.0, 2.7.99]'
133-
prefer '2.7.1'
134-
}
135-
}
13681

137-
testImplementation("junit:junit:4.13.2")
82+
testImplementation("junit:junit:$junitVersion")
13883
testImplementation("io.kotest:kotest-runner-junit4:$kotestVersion")
13984
testImplementation("io.kotest:kotest-runner-junit4-jvm:$kotestVersion")
14085
testImplementation("io.kotest:kotest-assertions-core:$kotestVersion")
@@ -144,7 +89,7 @@ dependencies {
14489
testImplementation("androidx.test:core:1.4.0")
14590
testImplementation("io.mockk:mockk:1.13.2")
14691
testImplementation("org.json:json:20180813")
147-
testImplementation "org.jetbrains.kotlin:kotlin-reflect:$kotlinVersion"
92+
testImplementation("org.jetbrains.kotlin:kotlin-reflect:$kotlinVersion")
14893
}
14994

15095
apply from: 'maven-push.gradle'

0 commit comments

Comments
 (0)