Merge pull request #1637 from OneSignal/add-detekt

Add Static Analyzer

Author: jmadler

.github/workflows/ci.yml

@@ -29,6 +29,11 @@ jobs:
         working-directory: OneSignalSDK
         run: |
           ./gradlew ktlintCheck --console=plain
+      - name: "[Test] Analyzing"
+        working-directory: OneSignalSDK
+        continue-on-error: true
+        run: |
+          ./gradlew detekt --console=plain
       - name: "[Test] SDK Unit Tests"
         working-directory: OneSignalSDK
         run: |

OneSignalSDK/build.gradle

@@ -14,6 +14,7 @@ buildscript {
         huaweiHMSLocationVersion = '4.0.0.300'
         kotlinVersion = '1.4.32'
         ktlintVersion = '11.0.0'
+        detektVersion = '1.21.0'
         onesignalGradlePluginVersion = '[0.14.0, 0.99.99]'
     }
 
@@ -37,6 +38,7 @@ buildscript {
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
 
         classpath "org.jlleitschuh.gradle:ktlint-gradle:$ktlintVersion"
+        classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:$detektVersion"
 
         // OneSignal-Gradle-Plugin - Local testing
         // classpath 'com.onesignal:onesignal-gradle-plugin:[0.8.1, 0.99.99]'

OneSignalSDK/onesignal/build.gradle

@@ -7,6 +7,7 @@ ext {
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
 apply plugin: 'org.jlleitschuh.gradle.ktlint'
+apply plugin: 'io.gitlab.arturbosch.detekt'
 
 android {
     compileSdkVersion rootProject.buildVersions.compileSdkVersion