Remove failure block from external id

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

@@ -200,31 +200,8 @@ public static class SendTagsError {
       public String getMessage() { return message; }
    }
 
-   public enum ExternalIdErrorType {
-      REQUIRES_EXTERNAL_ID_AUTH, INVALID_OPERATION, NETWORK
-   }
-
-   public static class ExternalIdError {
-      private ExternalIdErrorType type;
-      private String message;
-
-      ExternalIdError(ExternalIdErrorType type, String message) {
-         this.type = type;
-         this.message = message;
-      }
-
-      public ExternalIdErrorType getType() {
-         return type;
-      }
-
-      public String getMessage() {
-         return message;
-      }
-   }
-
    public interface OSExternalUserIdUpdateCompletionHandler {
       void onComplete(JSONObject results);
-      void onFailure(ExternalIdError error);
    }
 
    interface OSInternalExternalUserIdUpdateCompletionHandler {
@@ -1597,8 +1574,6 @@ public void run() {
 
             if (remoteParams != null && remoteParams.useUserIdAuth && externalIdAuthHash == null) {
                String errorMessage = "External Id authentication (auth token) is set to REQUIRED for this application. Please provide an auth token from your backend server or change the setting in the OneSignal dashboard.";
-               if (completionCallback != null)
-                  completionCallback.onFailure(new ExternalIdError(ExternalIdErrorType.REQUIRES_EXTERNAL_ID_AUTH, errorMessage));
                Log(LOG_LEVEL.ERROR, errorMessage);
                return;
             }

OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

@@ -122,7 +122,6 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.regex.Pattern;
 
-import static com.onesignal.OneSignal.ExternalIdErrorType.REQUIRES_EXTERNAL_ID_AUTH;
 import static com.onesignal.OneSignalPackagePrivateHelper.GcmBroadcastReceiver_processBundle;
 import static com.onesignal.OneSignalPackagePrivateHelper.NotificationBundleProcessor_Process;
 import static com.onesignal.OneSignalPackagePrivateHelper.NotificationOpenedProcessor_processFromContext;
@@ -215,18 +214,12 @@ public void notificationOpened(OSNotificationOpenResult openedResult) {
    }
 
    private static JSONObject lastExternalUserIdResponse;
-   private static OneSignal.ExternalIdError lastExternalUserIdError;
    private static OneSignal.OSExternalUserIdUpdateCompletionHandler getExternalUserIdUpdateCompletionHandler() {
       return new OneSignal.OSExternalUserIdUpdateCompletionHandler() {
          @Override
          public void onComplete(JSONObject results) {
             lastExternalUserIdResponse = results;
          }
-
-         @Override
-         public void onFailure(OneSignal.ExternalIdError error) {
-            lastExternalUserIdError = error;
-         }
       };
    }
 
@@ -244,8 +237,7 @@ private static void cleanUp() throws Exception {
 
       notificationOpenedMessage = null;
       lastGetTags = null;
-      lastExternalUserIdResponse = null;
-      lastExternalUserIdError = null;
+      lastExternalUserIdResponse = null;;
 
       ShadowGMSLocationController.reset();
       TestHelpers.beforeTestInitAndCleanup();
@@ -4143,9 +4135,6 @@ public void shouldSetExternalIdWithAuthHash() throws Exception {
 
       OneSignal.setExternalUserId(testExternalId, getExternalUserIdUpdateCompletionHandler());
       threadAndTaskWait();
-
-      assertNotNull(lastExternalUserIdError);
-      assertEquals(REQUIRES_EXTERNAL_ID_AUTH, lastExternalUserIdError.getType());
    }
 
    @Test