added NotificationLifecycleServiceTests

Author: jkasten2

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/internal/lifecycle/impl/NotificationLifecycleService.kt

@@ -37,9 +37,8 @@ import org.json.JSONException
 import org.json.JSONObject
 
 internal class NotificationLifecycleService(
-    applicationService: IApplicationService,
-    private val _time: ITime,
     private val _applicationService: IApplicationService,
+    private val _time: ITime,
     private val _configModelStore: ConfigModelStore,
     private val _influenceManager: IInfluenceManager,
     private val _subscriptionManager: ISubscriptionManager,
@@ -83,7 +82,7 @@ internal class NotificationLifecycleService(
     override fun removeExternalClickListener(listener: INotificationClickListener) = extOpenedCallback.unsubscribe(listener)
 
     init {
-        setupNotificationServiceExtension(applicationService.appContext)
+        setupNotificationServiceExtension(_applicationService.appContext)
     }
 
     override suspend fun canReceiveNotification(jsonPayload: JSONObject): Boolean {

OneSignalSDK/onesignal/notifications/src/test/java/com/onesignal/notifications/internal/lifecycle/NotificationLifecycleServiceTests.kt

@@ -0,0 +1,97 @@
+package com.onesignal.notifications.internal.lifecycle
+
+import android.app.Activity
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
+import br.com.colman.kotest.android.extensions.robolectric.RobolectricTest
+import com.onesignal.core.internal.application.impl.ApplicationService
+import com.onesignal.core.internal.device.IDeviceService
+import com.onesignal.debug.LogLevel
+import com.onesignal.debug.internal.logging.Logging
+import com.onesignal.mocks.MockHelper
+import com.onesignal.notifications.internal.analytics.IAnalyticsTracker
+import com.onesignal.notifications.internal.backend.INotificationBackendService
+import com.onesignal.notifications.internal.lifecycle.impl.NotificationLifecycleService
+import com.onesignal.notifications.internal.receivereceipt.IReceiveReceiptWorkManager
+import com.onesignal.notifications.shadows.ShadowRoboNotificationManager
+import com.onesignal.session.internal.influence.IInfluenceManager
+import com.onesignal.user.internal.subscriptions.ISubscriptionManager
+import com.onesignal.user.subscriptions.IPushSubscription
+import io.kotest.core.spec.style.FunSpec
+import io.mockk.coEvery
+import io.mockk.coVerify
+import io.mockk.every
+import io.mockk.mockk
+import io.mockk.spyk
+import org.json.JSONArray
+import org.json.JSONObject
+import org.robolectric.Robolectric
+
+@RobolectricTest
+class NotificationLifecycleServiceTests : FunSpec({
+    beforeAny {
+        Logging.logLevel = LogLevel.NONE
+        ShadowRoboNotificationManager.reset()
+    }
+
+    test("Fires openDestinationActivity") {
+        // Given
+        val context = ApplicationProvider.getApplicationContext<Context>()
+        val applicationService = ApplicationService()
+        applicationService.start(context)
+
+        val mockSubscriptionManager = mockk<ISubscriptionManager>()
+        every { mockSubscriptionManager.subscriptions.push } returns
+            mockk<IPushSubscription>().apply { every { id } returns "UUID1" }
+
+        val notificationLifecycleService =
+            spyk(
+                NotificationLifecycleService(
+                    applicationService,
+                    MockHelper.time(0),
+                    MockHelper.configModelStore(),
+                    mockk<IInfluenceManager>().apply {
+                        every { onDirectInfluenceFromNotification(any()) } returns Unit
+                    },
+                    mockSubscriptionManager,
+                    mockk<IDeviceService>().apply {
+                        every { deviceType } returns IDeviceService.DeviceType.Android
+                    },
+                    mockk<INotificationBackendService>().apply {
+                        coEvery { updateNotificationAsOpened(any(), any(), any(), any()) } returns Unit
+                    },
+                    mockk<IReceiveReceiptWorkManager>(),
+                    mockk<IAnalyticsTracker>().apply {
+                        every { trackOpenedEvent(any(), any()) } returns Unit
+                    },
+                ),
+            )
+        val activity: Activity
+        Robolectric.buildActivity(Activity::class.java).use { controller ->
+            controller.setup() // Moves Activity to RESUMED state
+            activity = controller.get()
+        }
+
+        // When
+        val payload =
+            JSONArray()
+                .put(
+                    JSONObject()
+                        .put("alert", "test message")
+                        .put(
+                            "custom",
+                            JSONObject()
+                                .put("i", "UUID1"),
+                        ),
+                )
+        notificationLifecycleService.notificationOpened(activity, payload)
+
+        // Then
+        coVerify(exactly = 1) {
+            notificationLifecycleService.openDestinationActivity(
+                withArg { Any() },
+                withArg { Any() },
+            )
+        }
+    }
+})