Skip to content

Commit 56c103e

Browse files
jkasten2jkasten2
committed
Force LooperMode.Mode.LEGACY
* LooperMode.Mode.PAUSED was first interduced in Roboeletric 4.3 and is default in 4.4. * We haven't migrated our code to use PAUSED yet so forcing LEGACY * Roboelectric's blog post on this new PAUSED mode: http://robolectric.org/blog/2019/06/04/paused-looper/
1 parent 80c79c5 commit 56c103e

13 files changed

+27
-1
lines changed

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/GenerateNotificationRunner.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@
9696
import org.robolectric.Shadows;
9797
import org.robolectric.android.controller.ActivityController;
9898
import org.robolectric.annotation.Config;
99+
import org.robolectric.annotation.LooperMode;
99100
import org.robolectric.shadows.ShadowLog;
100101

101102
import java.lang.reflect.Field;
@@ -153,6 +154,7 @@
153154
sdk = 21
154155
)
155156
@RunWith(RobolectricTestRunner.class)
157+
@LooperMode(LooperMode.Mode.LEGACY)
156158
public class GenerateNotificationRunner {
157159

158160
private static int callbackCounter = 0;

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/InAppMessageIntegrationTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
import org.robolectric.RobolectricTestRunner;
4848
import org.robolectric.android.controller.ActivityController;
4949
import org.robolectric.annotation.Config;
50+
import org.robolectric.annotation.LooperMode;
5051
import org.robolectric.shadows.ShadowLog;
5152

5253
import java.lang.reflect.Field;
@@ -92,6 +93,7 @@
9293
sdk = 21
9394
)
9495
@RunWith(RobolectricTestRunner.class)
96+
@LooperMode(LooperMode.Mode.LEGACY)
9597
public class InAppMessageIntegrationTests {
9698

9799
private static final String ONESIGNAL_APP_ID = "b2f7f966-d8cc-11e4-bed1-df8f05be55ba";

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/InAppMessagingUnitTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.robolectric.RobolectricTestRunner;
3737
import org.robolectric.android.controller.ActivityController;
3838
import org.robolectric.annotation.Config;
39+
import org.robolectric.annotation.LooperMode;
3940
import org.robolectric.shadows.ShadowLog;
4041

4142
import java.util.ArrayList;
@@ -70,6 +71,7 @@
7071
sdk = 26
7172
)
7273
@RunWith(RobolectricTestRunner.class)
74+
@LooperMode(LooperMode.Mode.LEGACY)
7375
public class InAppMessagingUnitTests {
7476

7577
private static final String IAM_CLICK_ID = "button_id_123";

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/LocationIntegrationTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
import org.robolectric.android.controller.ActivityController;
5353
import org.robolectric.annotation.Config;
5454
import org.robolectric.annotation.LooperMode;
55+
import org.robolectric.annotation.LooperMode;
5556
import org.robolectric.shadows.ShadowLog;
5657

5758
import java.lang.reflect.Method;
@@ -82,6 +83,7 @@
8283
sdk = 21
8384
)
8485
@RunWith(RobolectricTestRunner.class)
86+
@LooperMode(LooperMode.Mode.LEGACY)
8587
public class LocationIntegrationTests {
8688

8789
private static final String ONESIGNAL_APP_ID = "b4f7f966-d8cc-11e4-bed1-df8f05be55ba";

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
import org.robolectric.RuntimeEnvironment;
110110
import org.robolectric.android.controller.ActivityController;
111111
import org.robolectric.annotation.Config;
112+
import org.robolectric.annotation.LooperMode;
112113
import org.robolectric.shadows.ShadowAlarmManager;
113114
import org.robolectric.shadows.ShadowConnectivityManager;
114115
import org.robolectric.shadows.ShadowLog;
@@ -188,6 +189,7 @@
188189
sdk = 21
189190
)
190191
@RunWith(RobolectricTestRunner.class)
192+
@LooperMode(LooperMode.Mode.LEGACY)
191193
// Enable to ensure test order to consistency debug flaky test.
192194
// @FixMethodOrder(MethodSorters.NAME_ASCENDING)
193195
public class MainOneSignalClassRunner {
@@ -4011,4 +4013,4 @@ private static void AddLauncherIntentFilter() {
40114013

40124014
shadowOf(blankActivity.getPackageManager()).addResolveInfoForIntent(launchIntent, resolveInfo);
40134015
}
4014-
}
4016+
}

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/NotificationLimitManagerRunner.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.robolectric.RobolectricTestRunner;
2727
import org.robolectric.android.controller.ActivityController;
2828
import org.robolectric.annotation.Config;
29+
import org.robolectric.annotation.LooperMode;
2930
import org.robolectric.shadows.ShadowLog;
3031

3132
import static com.onesignal.OneSignalPackagePrivateHelper.NotificationBundleProcessor_ProcessFromFCMIntentService;
@@ -47,6 +48,7 @@
4748
sdk = 26
4849
)
4950
@RunWith(RobolectricTestRunner.class)
51+
@LooperMode(LooperMode.Mode.LEGACY)
5052
public class NotificationLimitManagerRunner {
5153

5254
private BlankActivity blankActivity;

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/NotificationOpenedActivityHMSIntegrationTestsRunner.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import org.robolectric.RobolectricTestRunner;
3232
import org.robolectric.android.controller.ActivityController;
3333
import org.robolectric.annotation.Config;
34+
import org.robolectric.annotation.LooperMode;
3435
import org.robolectric.shadows.ShadowLog;
3536

3637
import java.util.UUID;
@@ -63,6 +64,7 @@
6364
sdk = 26
6465
)
6566
@RunWith(RobolectricTestRunner.class)
67+
@LooperMode(LooperMode.Mode.LEGACY)
6668
public class NotificationOpenedActivityHMSIntegrationTestsRunner {
6769

6870
private static final String TEST_ACTION_ID = "myTestActionId";

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/OneSignalInitializationIntegrationTestsRunner.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.robolectric.RobolectricTestRunner;
2121
import org.robolectric.android.controller.ActivityController;
2222
import org.robolectric.annotation.Config;
23+
import org.robolectric.annotation.LooperMode;
2324
import org.robolectric.shadows.ShadowLog;
2425

2526
import static com.onesignal.OneSignalPackagePrivateHelper.MIN_ON_SESSION_TIME_MILLIS;
@@ -41,6 +42,7 @@
4142
)
4243

4344
@RunWith(RobolectricTestRunner.class)
45+
@LooperMode(LooperMode.Mode.LEGACY)
4446
public class OneSignalInitializationIntegrationTestsRunner {
4547
private ActivityController<BlankActivity> blankActivityController;
4648
private MockOSTimeImpl time;

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/OneSignalPrefsRunner.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import org.robolectric.RobolectricTestRunner;
2121
import org.robolectric.android.controller.ActivityController;
2222
import org.robolectric.annotation.Config;
23+
import org.robolectric.annotation.LooperMode;
2324
import org.robolectric.shadows.ShadowLog;
2425

2526
import static com.onesignal.ShadowOneSignalRestClient.setRemoteParamsGetHtmlResponse;
@@ -34,6 +35,7 @@
3435
sdk = 21
3536
)
3637
@RunWith(RobolectricTestRunner.class)
38+
@LooperMode(LooperMode.Mode.LEGACY)
3739
public class OneSignalPrefsRunner {
3840

3941
private static final String ONESIGNAL_APP_ID = "b4f7f966-d8cc-11e4-bed1-df8f05be55ba";

‎OneSignalSDK/unittest/src/test/java/com/test/onesignal/OutcomeEventIntegrationTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
import org.robolectric.RobolectricTestRunner;
4848
import org.robolectric.android.controller.ActivityController;
4949
import org.robolectric.annotation.Config;
50+
import org.robolectric.annotation.LooperMode;
5051
import org.robolectric.shadows.ShadowLog;
5152
import org.robolectric.shadows.ShadowPausedSystemClock;
5253

@@ -95,6 +96,7 @@
9596
},
9697
sdk = 26)
9798
@RunWith(RobolectricTestRunner.class)
99+
@LooperMode(LooperMode.Mode.LEGACY)
98100
public class OutcomeEventIntegrationTests {
99101

100102
private static final String ONESIGNAL_APP_ID = "b2f7f966-d8cc-11e4-bed1-df8f05be55ba";

0 commit comments

Comments
 (0)