Skip to content

Commit 54fb095

Browse files
committed
Don't throw for bad email and sms tokens
1 parent 67912a4 commit 54fb095

File tree

1 file changed

+8
-4
lines changed
  • OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal

1 file changed

+8
-4
lines changed

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/UserManager.kt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@ internal open class UserManager(
122122
Logging.log(LogLevel.DEBUG, "addEmail(email: $email)")
123123

124124
if (!OneSignalUtils.isValidEmail(email)) {
125-
throw Exception("Cannot add invalid email address as subscription: $email")
125+
Logging.log(LogLevel.ERROR, "Cannot add invalid email address as subscription: $email")
126+
return
126127
}
127128

128129
_subscriptionManager.addEmailSubscription(email)
@@ -132,7 +133,8 @@ internal open class UserManager(
132133
Logging.log(LogLevel.DEBUG, "removeEmail(email: $email)")
133134

134135
if (!OneSignalUtils.isValidEmail(email)) {
135-
throw Exception("Cannot remove invalid email address as subscription: $email")
136+
Logging.log(LogLevel.ERROR, "Cannot remove invalid email address as subscription: $email")
137+
return
136138
}
137139

138140
_subscriptionManager.removeEmailSubscription(email)
@@ -142,7 +144,8 @@ internal open class UserManager(
142144
Logging.log(LogLevel.DEBUG, "addSms(sms: $sms)")
143145

144146
if (!OneSignalUtils.isValidPhoneNumber(sms)) {
145-
throw Exception("Cannot add invalid sms number as subscription: $sms")
147+
Logging.log(LogLevel.ERROR, "Cannot add invalid sms number as subscription: $sms")
148+
return
146149
}
147150

148151
_subscriptionManager.addSmsSubscription(sms)
@@ -152,7 +155,8 @@ internal open class UserManager(
152155
Logging.log(LogLevel.DEBUG, "removeSms(sms: $sms)")
153156

154157
if (!OneSignalUtils.isValidPhoneNumber(sms)) {
155-
throw Exception("Cannot remove invalid sms number as subscription: $sms")
158+
Logging.log(LogLevel.ERROR, "Cannot remove invalid sms number as subscription: $sms")
159+
return
156160
}
157161

158162
_subscriptionManager.removeSmsSubscription(sms)

0 commit comments

Comments
 (0)