Skip to content

Commit 526539b

Browse files
jennantillajinliu9508
authored andcommitted
Fix comment linting errors
1 parent 6d8c526 commit 526539b

File tree

7 files changed

+28
-9
lines changed

7 files changed

+28
-9
lines changed

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/RootToolsInternalMethods.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Namespaced in com.onesignal to prevent class name conflicts if app developer includes the full RootTools library.
2+
13
/**
24
* This file is part of the RootTools Project: http://code.google.com/p/roottools/
35
*
@@ -20,7 +22,6 @@
2022
* limitations under that License.
2123
*/
2224

23-
// Namespaced in com.onesignal to prevent class name conflicts if app developer includes the full RootTools library.
2425
package com.onesignal.common
2526

2627
import java.io.File

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/backend/impl/ParamsBackendService.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ internal class ParamsBackendService(
5959
return ParamsObject(
6060
googleProjectNumber = responseJson.safeString("android_sender_id"),
6161
enterprise = responseJson.safeBool("enterp"),
62-
useIdentityVerification = responseJson.safeBool("require_ident_auth"), // TODO: New
62+
// TODO: New
63+
useIdentityVerification = responseJson.safeBool("require_ident_auth"),
6364
notificationChannels = responseJson.optJSONArray("chnl_lst"),
6465
firebaseAnalytics = responseJson.safeBool("fba"),
6566
restoreTTLFilter = responseJson.safeBool("restore_ttl_filter"),
@@ -69,7 +70,8 @@ internal class ParamsBackendService(
6970
unsubscribeWhenNotificationsDisabled = responseJson.safeBool("unsubscribe_on_notifications_disabled"),
7071
locationShared = responseJson.safeBool("location_shared"),
7172
requiresUserPrivacyConsent = responseJson.safeBool("requires_user_privacy_consent"),
72-
opRepoExecutionInterval = responseJson.safeLong("oprepo_execution_interval"), // TODO: New
73+
// TODO: New
74+
opRepoExecutionInterval = responseJson.safeLong("oprepo_execution_interval"),
7375
influenceParams = influenceParams ?: InfluenceParamsObject(),
7476
fcmParams = fcmParams ?: FCMParamsObject(),
7577
)

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/preferences/IPreferencesService.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ object PreferenceStores {
162162

163163
object PreferencePlayerPurchasesKeys {
164164
// Player Purchase Keys
165+
165166
/**
166167
* (String) The purchase tokens that have been tracked.
167168
*/
@@ -175,6 +176,7 @@ object PreferencePlayerPurchasesKeys {
175176

176177
object PreferenceOneSignalKeys {
177178
// Legacy
179+
178180
/**
179181
* (String) The legacy player ID from SDKs prior to 5.
180182
*/
@@ -186,19 +188,22 @@ object PreferenceOneSignalKeys {
186188
const val PREFS_LEGACY_USER_SYNCVALUES = "ONESIGNAL_USERSTATE_SYNCVALYES_CURRENT_STATE"
187189

188190
// Location
191+
189192
/**
190193
* (Long) The last time the device location was captured, in Unix time milliseconds.
191194
*/
192195
const val PREFS_OS_LAST_LOCATION_TIME = "OS_LAST_LOCATION_TIME"
193196

194197
// Permissions
198+
195199
/**
196200
* (Boolean) A prefix key for the permission state. When true, the user has rejected this
197201
* permission too many times and will not be prompted again.
198202
*/
199203
const val PREFS_OS_USER_RESOLVED_PERMISSION_PREFIX = "USER_RESOLVED_PERMISSION_"
200204

201205
// HTTP
206+
202207
/**
203208
* (String) A prefix key for retrieving the ETAG for a given HTTP GET cache key. The cache
204209
* key should be appended to this prefix.
@@ -212,12 +217,14 @@ object PreferenceOneSignalKeys {
212217
const val PREFS_OS_HTTP_CACHE_PREFIX = "PREFS_OS_HTTP_CACHE_PREFIX_"
213218

214219
// Outcomes
220+
215221
/**
216222
* (String Set) The set of unattributed outcome events that have occurred to ensure uniqueness when requested.
217223
*/
218224
const val PREFS_OS_UNATTRIBUTED_UNIQUE_OUTCOME_EVENTS_SENT = "PREFS_OS_UNATTRIBUTED_UNIQUE_OUTCOME_EVENTS_SENT"
219225

220226
// In-App Messaging
227+
221228
/**
222229
* (String) The serialized IAMs TODO: This isn't currently used, determine if actually needed for cold start IAM fetch delay
223230
*/
@@ -249,6 +256,7 @@ object PreferenceOneSignalKeys {
249256
const val PREFS_OS_IAM_LAST_DISMISSED_TIME = "PREFS_OS_IAM_LAST_DISMISSED_TIME"
250257

251258
// Models
259+
252260
/**
253261
* (String) A prefix key for retrieving a specific model store contents. The name of the model
254262
* store should be appended to this prefix.

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/session/internal/outcomes/impl/OutcomeEventParams.kt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,14 @@ import org.json.JSONObject
55

66
internal class OutcomeEventParams constructor(
77
val outcomeId: String,
8-
val outcomeSource: OutcomeSource?, // This field is optional
9-
var weight: Float, // This field is optional.
10-
var sessionTime: Long, // This field is optional
11-
var timestamp: Long, // This should start out as zero
8+
// This field is optional
9+
val outcomeSource: OutcomeSource?,
10+
// This field is optional
11+
var weight: Float,
12+
// This field is optional
13+
var sessionTime: Long,
14+
// This should start out as zero
15+
var timestamp: Long,
1216
) {
1317
@Throws(JSONException::class)
1418
fun toJSONObject(): JSONObject {

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/session/internal/outcomes/impl/OutcomeEventsController.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,8 @@ Outcome event was cached and will be reattempted on app cold start""",
173173
private suspend fun sendAndCreateOutcomeEvent(
174174
name: String,
175175
weight: Float,
176-
sessionTime: Long, // Note: this is optional
176+
// Note: this is optional
177+
sessionTime: Long,
177178
influences: List<Influence>,
178179
): OutcomeEvent? {
179180
val timestampSeconds: Long = _time.currentTimeMillis / 1000

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/session/internal/outcomes/impl/OutcomeEventsPreferences.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ internal class OutcomeEventsPreferences(
1717
set(value) {
1818
preferences.saveStringSet(
1919
PreferenceStores.ONESIGNAL,
20-
PreferenceOneSignalKeys.PREFS_OS_UNATTRIBUTED_UNIQUE_OUTCOME_EVENTS_SENT, // Post success, store unattributed unique outcome event names
20+
// Post success, store unattributed unique outcome event names
21+
PreferenceOneSignalKeys.PREFS_OS_UNATTRIBUTED_UNIQUE_OUTCOME_EVENTS_SENT,
2122
value,
2223
)
2324
}

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/subscriptions/SubscriptionModel.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ enum class SubscriptionStatus(val value: Int) {
4848
FIREBASE_FCM_ERROR_MISC_EXCEPTION(-12),
4949

5050
// -13 to -24 reserved for other platforms
51+
5152
/** The subscription is not enabled due the an HMS timeout, this can be retried */
5253
HMS_TOKEN_TIMEOUT(-25),
5354

5455
// Most likely missing "client/app_id".
5556
// Check that there is "apply plugin: 'com.huawei.agconnect'" in your app/build.gradle
57+
5658
/** The subscription is not enabled due to the HMS arguments being invalid */
5759
HMS_ARGUMENTS_INVALID(-26),
5860

0 commit comments

Comments
 (0)