Skip to content

Commit 5155827

Browse files
authored
Merge pull request #2049 from OneSignal/fix/rm_alias_duplicate_calls_handling
[Fix] Don't re-create user on failed remove alias
2 parents 1c9bf66 + c9dbe18 commit 5155827

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/IdentityOperationExecutor.kt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,10 @@ internal class IdentityOperationExecutor(
103103
NetworkUtils.ResponseStatusType.UNAUTHORIZED ->
104104
ExecutionResponse(ExecutionResult.FAIL_UNAUTHORIZED)
105105
NetworkUtils.ResponseStatusType.MISSING -> {
106-
val operations = _buildUserService.getRebuildOperationsIfCurrentUser(lastOperation.appId, lastOperation.onesignalId)
107-
if (operations == null) {
108-
return ExecutionResponse(ExecutionResult.FAIL_NORETRY)
109-
} else {
110-
return ExecutionResponse(ExecutionResult.FAIL_RETRY, operations = operations)
111-
}
106+
// This means either the User or the Alias was already
107+
// deleted, either way the end state is the same, the
108+
// alias no longer exists on that User.
109+
ExecutionResponse(ExecutionResult.SUCCESS)
112110
}
113111
}
114112
}

0 commit comments

Comments
 (0)