Skip to content

Commit 44cc817

Browse files
authored
Merge pull request #114 from OneSignal/manifestApplicationId_removal
Removed manifestApplicationId requirement
2 parents 098d216 + c48ffd1 commit 44cc817

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

Examples/AndroidStudio/app/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ android {
88
applicationId "com.onesignal.example"
99

1010
// TODO: Please update the Google Project number and OneSignal Id below to yours.
11-
manifestPlaceholders = [manifestApplicationId: "${applicationId}",
12-
onesignal_app_id: "b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
11+
manifestPlaceholders = [onesignal_app_id: "b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
1312
onesignal_google_project_number: "703322744261"]
1413

1514
minSdkVersion 10

Examples/AndroidStudioAmazon/app/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ android {
88
applicationId "com.onesignal.example"
99

1010
// TODO: Please update the Google Project number and OneSignal Id below to yours.
11-
manifestPlaceholders = [manifestApplicationId: "${applicationId}",
12-
onesignal_app_id: "b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
11+
manifestPlaceholders = [onesignal_app_id: "b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
1312
onesignal_google_project_number: "703322744261"]
1413

1514
minSdkVersion 10

OneSignalSDK/app/build.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ android {
66

77
defaultConfig {
88
applicationId "com.onesignal.example"
9-
manifestPlaceholders = [manifestApplicationId: "${applicationId}",
10-
// onesignal_app_id: "5eb5a37e-b458-11e3-ac11-000c2940e62c",
11-
onesignal_app_id: "b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
9+
manifestPlaceholders = [onesignal_app_id: "b2f7f966-d8cc-11e4-bed1-df8f05be55ba",
1210
onesignal_google_project_number: "703322744261"]
1311
minSdkVersion 9
1412
targetSdkVersion 24

OneSignalSDK/onesignal/src/release/AndroidManifest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.onesignal">
22

33
<!-- Create a unique permission for your app and use it so only your app can receive your OneSignal messages. -->
4-
<permission android:name="${manifestApplicationId}.permission.C2D_MESSAGE" android:protectionLevel="signature" />
5-
<uses-permission android:name="${manifestApplicationId}.permission.C2D_MESSAGE" />
4+
<permission android:name="${applicationId}.permission.C2D_MESSAGE" android:protectionLevel="signature" />
5+
<uses-permission android:name="${applicationId}.permission.C2D_MESSAGE" />
66

77
<application>
88
<meta-data android:name="onesignal_app_id" android:value="${onesignal_app_id}" />
@@ -13,7 +13,7 @@
1313
android:permission="com.google.android.c2dm.permission.SEND" >
1414
<intent-filter>
1515
<action android:name="com.google.android.c2dm.intent.RECEIVE" />
16-
<category android:name="${manifestApplicationId}" />
16+
<category android:name="${applicationId}" />
1717
</intent-filter>
1818
</receiver>
1919
</application>

0 commit comments

Comments
 (0)