Update existing cache key usage to use OptionalHeaders

Author: Rodrigo Gomez Palacio

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/backend/impl/ParamsBackendService.kt

@@ -13,6 +13,7 @@ import com.onesignal.core.internal.backend.InfluenceParamsObject
 import com.onesignal.core.internal.backend.ParamsObject
 import com.onesignal.core.internal.http.CacheKeys
 import com.onesignal.core.internal.http.IHttpClient
+import com.onesignal.core.internal.http.impl.OptionalHeaderValues
 import com.onesignal.debug.LogLevel
 import com.onesignal.debug.internal.logging.Logging
 import org.json.JSONObject
@@ -31,7 +32,9 @@ internal class ParamsBackendService(
             paramsUrl += "?player_id=$subscriptionId"
         }
 
-        val response = _http.get(paramsUrl, CacheKeys.REMOTE_PARAMS)
+        val headers = OptionalHeaderValues()
+        headers.cacheKey = CacheKeys.REMOTE_PARAMS
+        val response = _http.get(paramsUrl, headers)
 
         if (!response.isSuccess) {
             throw BackendException(response.statusCode, response.payload, response.retryAfterSeconds)

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/core/internal/http/HttpClientTests.kt

@@ -3,6 +3,7 @@ package com.onesignal.core.internal.http
 import com.onesignal.common.OneSignalUtils
 import com.onesignal.core.internal.device.impl.InstallIdService
 import com.onesignal.core.internal.http.impl.HttpClient
+import com.onesignal.core.internal.http.impl.OptionalHeaderValues
 import com.onesignal.core.internal.time.impl.Time
 import com.onesignal.debug.LogLevel
 import com.onesignal.debug.internal.logging.Logging
@@ -88,9 +89,11 @@ class HttpClientTests : FunSpec({
         val httpClient = mocks.httpClient
 
         // When
-        val response1 = httpClient.get("URL", "CACHE_KEY")
+        val headerValues = OptionalHeaderValues()
+        headerValues.cacheKey = "CACHE_KEY"
+        val response1 = httpClient.get("URL", headerValues)
         factory.mockResponse = mockResponse2
-        val response2 = httpClient.get("URL", "CACHE_KEY")
+        val response2 = httpClient.get("URL", headerValues)
 
         // Then
         response1.statusCode shouldBe 200
@@ -123,13 +126,15 @@ class HttpClientTests : FunSpec({
         val httpClient = mocks.httpClient
 
         // When
-        val response1 = httpClient.get("URL", "CACHE_KEY")
+        val headerValues = OptionalHeaderValues()
+        headerValues.cacheKey = "CACHE_KEY"
+        val response1 = httpClient.get("URL", headerValues)
 
         factory.mockResponse = mockResponse2
-        val response2 = httpClient.get("URL", "CACHE_KEY")
+        val response2 = httpClient.get("URL", headerValues)
 
         factory.mockResponse = mockResponse3
-        val response3 = httpClient.get("URL", "CACHE_KEY")
+        val response3 = httpClient.get("URL", headerValues)
 
         // Then
         response1.statusCode shouldBe 200