Removed public idsAvailable method

* As well as it's matching OSIdsAvailableHandler
* Replaced by getDeviceState and / or addSubscriptionObserver depending
on how you were using idsAvailable.
* Removed implemention as well internal methods supporting it

Author: jkasten2

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

@@ -195,10 +195,6 @@ public interface OSInAppMessageClickHandler {
       void inAppMessageClicked(OSInAppMessageAction result);
    }
 
-   public interface OSIdsAvailableHandler {
-      void idsAvailable(String userId, String registrationId);
-   }
-
    /**
     * Interface which you can implement and pass to {@link OneSignal#getTags(OSGetTagsHandler)} to
     * get all the tags set on a user
@@ -326,8 +322,6 @@ static boolean isInForeground() {
       return appEntryState;
    }
 
-   private static OSIdsAvailableHandler idsAvailableHandler;
-
    private static TrackGooglePurchase trackGooglePurchase;
    private static TrackAmazonPurchase trackAmazonPurchase;
    private static TrackFirebaseAnalytics trackFirebaseAnalytics;
@@ -1845,65 +1839,6 @@ public static void deleteTags(JSONArray jsonArray, ChangeTagsUpdateHandler handl
       }
    }
 
-   public static void idsAvailable(final OSIdsAvailableHandler inIdsAvailableHandler) {
-      if (taskController.shouldQueueTaskForInit(OSTaskController.IDS_AVAILABLE)) {
-         logger.error("Waiting for remote params. " +
-                 "Moving " + OSTaskController.IDS_AVAILABLE + " operation to a pending queue.");
-         taskController.addTaskToQueue(new Runnable() {
-            @Override
-            public void run() {
-               logger.debug("Running " + OSTaskController.IDS_AVAILABLE + " operation from pending queue.");
-               idsAvailable(inIdsAvailableHandler);
-            }
-         });
-         return;
-      }
-
-      // If applicable, check if the user provided privacy consent
-      if (shouldLogUserPrivacyConsentErrorMessageForMethodName(OSTaskController.IDS_AVAILABLE))
-         return;
-
-      idsAvailableHandler = inIdsAvailableHandler;
-
-      if (getUserId() != null) {
-         OSUtils.runOnMainUIThread(new Runnable() {
-            @Override
-            public void run() {
-               internalFireIdsAvailableCallback();
-            }
-         });
-      }
-   }
-
-   static void fireIdsAvailableCallback() {
-      if (idsAvailableHandler != null) {
-         OSUtils.runOnMainUIThread(new Runnable() {
-            @Override
-            public void run() {
-               internalFireIdsAvailableCallback();
-            }
-         });
-      }
-   }
-
-   private synchronized static void internalFireIdsAvailableCallback() {
-      if (idsAvailableHandler == null)
-         return;
-
-      String regId = OneSignalStateSynchronizer.getRegistrationId();
-      if (!OneSignalStateSynchronizer.getSubscribed())
-         regId = null;
-
-      String userId = getUserId();
-      if (userId == null)
-         return;
-
-      idsAvailableHandler.idsAvailable(userId, regId);
-
-      if (regId != null)
-         idsAvailableHandler = null;
-   }
-
    static void sendPurchases(JSONArray purchases, boolean newAsExisting, OneSignalRestClient.ResponseHandler responseHandler) {
 
       //if applicable, check if the user provided privacy consent
@@ -2269,7 +2204,6 @@ static void saveEmailId(String id) {
    // Updates anything else that might have been waiting for this id.
    static void updateUserIdDependents(String userId) {
       saveUserId(userId);
-      fireIdsAvailableCallback();
       internalFireGetTagsCallbacks();
 
       getCurrentSubscriptionState(appContext).setUserId(userId);

OneSignalSDK/onesignal/src/main/java/com/onesignal/UserStatePushSynchronizer.java

@@ -185,7 +185,5 @@ protected void fireEventsForUpdateFailure(JSONObject jsonFields) {
     protected void onSuccessfulSync(JSONObject jsonFields) {
         if (jsonFields.has("email"))
             OneSignal.fireEmailUpdateSuccess();
-        if (jsonFields.has("identifier"))
-            OneSignal.fireIdsAvailableCallback();
     }
 }