Skip to content

Commit 329fb23

Browse files
committed
add error log and clarify comments
1 parent f09845a commit 329fb23

File tree

1 file changed

+8
-3
lines changed
  • OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/internal/common

1 file changed

+8
-3
lines changed

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/internal/common/OSWorkManagerHelper.kt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import android.content.Context
55
import androidx.work.Configuration
66
import androidx.work.WorkManager
77
import androidx.work.impl.WorkManagerImpl
8+
import com.onesignal.debug.internal.logging.Logging
89

910
object OSWorkManagerHelper {
1011
/**
@@ -34,11 +35,15 @@ object OSWorkManagerHelper {
3435
fun getInstance(context: Context): WorkManager {
3536
if (!isInitialized()) {
3637
try {
37-
// Initialization can fail if another thread initializes in the small time gap
38-
// https://android.googlesource.com/platform/frameworks/support/+/60ae0eec2a32396c22ad92502cde952c80d514a0/work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java#177
3938
WorkManager.initialize(context, Configuration.Builder().build())
4039
} catch (e: IllegalStateException) {
41-
// Admittedly starting to get hacky
40+
/*
41+
This catch is meant for the exception -
42+
https://android.googlesource.com/platform/frameworks/support/+/60ae0eec2a32396c22ad92502cde952c80d514a0/work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java#177
43+
1. We lost the race with another call to WorkManager.initialize outside of OneSignal.
44+
2. It is possible for some other unexpected error is thrown from WorkManager.
45+
*/
46+
Logging.error("OSWorkManagerHelper initializing WorkManager failed: ", e)
4247
}
4348
}
4449
return WorkManager.getInstance(context)

0 commit comments

Comments
 (0)