Skip to content

Commit 31f80d2

Browse files
committed
Added @workerthread and more specific throws
1 parent 6473567 commit 31f80d2

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/PushRegistratorFCM.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,22 @@
3333
import android.util.Base64;
3434

3535
import android.support.annotation.NonNull;
36+
import android.support.annotation.WorkerThread;
3637

38+
import com.google.android.gms.tasks.Task;
39+
import com.google.android.gms.tasks.Tasks;
3740
import com.google.firebase.FirebaseApp;
3841
import com.google.firebase.FirebaseOptions;
3942
import com.google.firebase.iid.FirebaseInstanceId;
4043
import com.google.firebase.iid.FirebaseInstanceIdService;
4144
import com.google.firebase.messaging.FirebaseMessaging;
4245

46+
import java.io.IOException;
47+
import java.util.concurrent.ExecutionException;
48+
4349
// TODO: 4.0.0 - Switch to using <action android:name="com.google.firebase.INSTANCE_ID_EVENT"/>
4450
// Note: Starting with Firebase Messaging 17.1.0 onNewToken in FirebaseMessagingService should be
4551
// used instead.
46-
4752
class PushRegistratorFCM extends PushRegistratorAbstractGoogle {
4853

4954
// project_info.project_id
@@ -88,8 +93,9 @@ String getProviderName() {
8893
return "FCM";
8994
}
9095

96+
@WorkerThread
9197
@Override
92-
String getToken(String senderId) throws Throwable {
98+
String getToken(String senderId) throws ExecutionException, InterruptedException, IOException {
9399
initFirebaseApp(senderId);
94100

95101
try {
@@ -106,6 +112,7 @@ String getToken(String senderId) throws Throwable {
106112
return getTokenWithClassFirebaseInstanceId(senderId);
107113
}
108114

115+
@WorkerThread
109116
private String getTokenWithClassFirebaseInstanceId(String senderId) throws IOException {
110117
FirebaseInstanceId instanceId = FirebaseInstanceId.getInstance(firebaseApp);
111118
return instanceId.getToken(senderId, FirebaseMessaging.INSTANCE_ID_SCOPE);

0 commit comments

Comments
 (0)