Add Main thread check under OSNotificationReceivedEvent

* Flutter invoked methods are runned under MainThread, OSNotificationReceivedEvent complete method ends calling a MainThread check that crashes.
* Add MainThread check under OSNotificationReceivedEvent complete method
* If running on MainThread create a new thread to complete the notification

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSNotificationReceivedEvent.java

@@ -67,7 +67,7 @@ public void run() {
     * @param notification can be null to omit displaying the notification,
     *                     or OSMutableNotification to modify the notification to display
     */
-   public synchronized void complete(@Nullable OSNotification notification) {
+   public synchronized void complete(@Nullable final OSNotification notification) {
       timeoutHandler.destroyTimeout(timeoutRunnable);
 
       if (isComplete) {
@@ -77,6 +77,20 @@ public synchronized void complete(@Nullable OSNotification notification) {
 
       isComplete = true;
 
+      if (OSUtils.isRunningOnMainThread()) {
+         new Thread(new Runnable() {
+            @Override
+            public void run() {
+               processNotification(notification);
+            }
+         }, "OS_COMPLETE_NOTIFICATION").start();
+         return;
+      }
+
+      processNotification(notification);
+   }
+
+   private void processNotification(@Nullable OSNotification notification) {
       // Pass copies to controller, to avoid modifying objects accessed by the user
       controller.processNotification(this.notification.copy(), notification != null ? notification.copy() : null);
    }

OneSignalSDK/unittest/src/test/java/com/onesignal/OneSignalPackagePrivateHelper.java

@@ -22,6 +22,7 @@
 import java.util.Set;
 import java.util.concurrent.ConcurrentLinkedQueue;
 
+import static com.test.onesignal.TestHelpers.threadAndTaskWait;
 import static org.robolectric.Shadows.shadowOf;
 
 public class OneSignalPackagePrivateHelper {
@@ -142,12 +143,13 @@ public static void FCMBroadcastReceiver_onReceived_withIntent(Context context, I
       receiver.onReceive(context, intent);
    }
 
-   public static void FCMBroadcastReceiver_onReceived_withBundle(Context context, Bundle bundle) {
+   public static void FCMBroadcastReceiver_onReceived_withBundle(Context context, Bundle bundle) throws Exception {
       FCMBroadcastReceiver receiver = new FCMBroadcastReceiver();
       Intent intent = new Intent();
       intent.setAction("com.google.android.c2dm.intent.RECEIVE");
       intent.putExtras(bundle);
       receiver.onReceive(context,intent);
+      threadAndTaskWait();
    }
 
    public static void HMSProcessor_processDataMessageReceived(final Context context, final String jsonStrPayload) {

OneSignalSDK/unittest/src/test/java/com/test/onesignal/GenerateNotificationRunner.java

@@ -1129,14 +1129,15 @@ public void shouldNotSetAlertnessFieldsOnLowPriority() throws Exception {
 
    @Test
    @Config(shadows = { ShadowGenerateNotification.class })
-   public void shouldSetExpireTimeCorrectlyFromGoogleTTL() {
+   public void shouldSetExpireTimeCorrectlyFromGoogleTTL() throws Exception {
       long sentTime = 1_553_035_338_000L;
       long ttl = 60L;
 
       Bundle bundle = getBaseNotifBundle();
       bundle.putLong("google.sent_time", sentTime);
       bundle.putLong("google.ttl", ttl);
       NotificationBundleProcessor_ProcessFromFCMIntentService(blankActivity, bundle);
+      threadAndTaskWait();
 
       HashMap<String, Object> notification = TestHelpers.getAllNotificationRecords(dbHelper).get(0);
       long expireTime = (Long)notification.get(NotificationTable.COLUMN_NAME_EXPIRE_TIME);
@@ -1145,8 +1146,9 @@ public void shouldSetExpireTimeCorrectlyFromGoogleTTL() {
 
    @Test
    @Config(shadows = { ShadowGenerateNotification.class })
-   public void shouldSetExpireTimeCorrectlyWhenMissingFromPayload() {
+   public void shouldSetExpireTimeCorrectlyWhenMissingFromPayload() throws Exception {
       NotificationBundleProcessor_ProcessFromFCMIntentService(blankActivity, getBaseNotifBundle());
+      threadAndTaskWait();
 
       long expireTime = (Long)TestHelpers.getAllNotificationRecords(dbHelper).get(0).get(NotificationTable.COLUMN_NAME_EXPIRE_TIME);
       assertEquals((SystemClock.currentThreadTimeMillis() / 1_000L) + 259_200, expireTime);

OneSignalSDK/unittest/src/test/java/com/test/onesignal/OutcomeEventIntegrationTests.java

@@ -694,7 +694,6 @@ public void testIndirectSession_fromDirectSession_afterNewSession() throws Excep
         // Receive notification
         Bundle bundle = getBaseNotifBundle(ONESIGNAL_NOTIFICATION_ID + "2");
         FCMBroadcastReceiver_onReceived_withBundle(blankActivity, bundle);
-        threadAndTaskWait();
 
         // Wait 31 seconds
         time.advanceSystemTimeBy(31);

OneSignalSDK/unittest/src/test/java/com/test/onesignal/TestHelpers.java

@@ -201,7 +201,7 @@ static Thread getThreadByName(String threadName) {
    }
 
    // Run any OneSignal background threads including any pending runnables
-   static void threadAndTaskWait() throws Exception {
+   public static void threadAndTaskWait() throws Exception {
       ShadowApplication.getInstance().getForegroundThreadScheduler().runOneTask();
       // Runs Runnables posted by calling View.post() which are run on the main thread.
       Robolectric.getForegroundThreadScheduler().runOneTask();