Skip to content

Commit 2750d61

Browse files
committed
Replace StateSynchronizer in OneSignal.setLanguage
1 parent 74504bf commit 2750d61

File tree

1 file changed

+14
-21
lines changed

1 file changed

+14
-21
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1578,18 +1578,21 @@ public void run() {
15781578
}
15791579

15801580
public static void setLanguage(@NonNull final String language) {
1581-
if (taskRemoteController.shouldQueueTaskForInit(OSTaskRemoteController.SET_LANGUAGE)) {
1582-
logger.error("Waiting for remote params. " +
1583-
"Moving " + OSTaskRemoteController.SET_LANGUAGE + " operation to a pending task queue.");
1584-
taskRemoteController.addTaskToQueue(new Runnable() {
1585-
@Override
1586-
public void run() {
1587-
logger.debug("Running " + OSTaskRemoteController.SET_LANGUAGE + " operation from pending task queue.");
1588-
setLanguage(language);
1581+
Runnable runSetLanguage = new Runnable() {
1582+
@Override
1583+
public void run() {
1584+
try {
1585+
JSONObject deviceInfo = new JSONObject();
1586+
deviceInfo.put("language", languageContext.getLanguage());
1587+
OneSignalStateSynchronizer.updateDeviceInfo(deviceInfo);
1588+
} catch (JSONException exception) {
1589+
String operation = language.equals("") ? "remove" : "set";
1590+
logger.error("Attempted to " + operation + " external ID but encountered a JSON exception");
1591+
exception.printStackTrace();
15891592
}
1590-
});
1591-
return;
1592-
}
1593+
}
1594+
};
1595+
runSetLanguage.run();
15931596

15941597
if (shouldLogUserPrivacyConsentErrorMessageForMethodName("setLanguage()"))
15951598
return;
@@ -1602,16 +1605,6 @@ public void run() {
16021605
LanguageProviderAppDefined languageProviderAppDefined = new LanguageProviderAppDefined();
16031606
languageProviderAppDefined.setLanguage(language);
16041607
languageContext.setStrategy(languageProviderAppDefined);
1605-
1606-
try {
1607-
JSONObject deviceInfo = new JSONObject();
1608-
deviceInfo.put("language", languageContext.getLanguage());
1609-
OneSignalStateSynchronizer.updateDeviceInfo(deviceInfo);
1610-
} catch (JSONException exception) {
1611-
String operation = language.equals("") ? "remove" : "set";
1612-
logger.error("Attempted to " + operation + " external ID but encountered a JSON exception");
1613-
exception.printStackTrace();
1614-
}
16151608
}
16161609

16171610
public static void setExternalUserId(@NonNull final String externalId) {

0 commit comments

Comments
 (0)