Skip to content

Commit 2728bb8

Browse files
committed
Fixing full bleed carousel width
1 parent b8fc929 commit 2728bb8

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/WebViewManager.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ private void handleRenderComplete(JSONObject jsonObject) {
259259

260260
private int getPageHeightData(JSONObject jsonObject) {
261261
try {
262-
return WebViewManager.pageRectToViewHeight(activity, jsonObject.getJSONObject(IAM_PAGE_META_DATA_KEY));
262+
return pageRectToViewHeight(activity, jsonObject.getJSONObject(IAM_PAGE_META_DATA_KEY));
263263
} catch (JSONException e) {
264264
return -1;
265265
}
@@ -306,7 +306,7 @@ private void handlePageChange(JSONObject jsonObject) throws JSONException {
306306
}
307307
}
308308

309-
private static int pageRectToViewHeight(final @NonNull Activity activity, @NonNull JSONObject jsonObject) {
309+
private int pageRectToViewHeight(final @NonNull Activity activity, @NonNull JSONObject jsonObject) {
310310
try {
311311
int pageHeight = jsonObject.getJSONObject("rect").getInt("height");
312312
int pxHeight = OSViewUtils.dpToPx(pageHeight);
@@ -507,12 +507,14 @@ private static void enableWebViewRemoteDebugging() {
507507
}
508508
}
509509

510-
private static int getWebViewMaxSizeX(Activity activity) {
511-
return OSViewUtils.getWindowWidth(activity) - (MARGIN_PX_SIZE * 2);
510+
private int getWebViewMaxSizeX(Activity activity) {
511+
int margin = messageContent.isFullScreen() ? 0 : (MARGIN_PX_SIZE * 2);
512+
return OSViewUtils.getWindowWidth(activity) - margin; //- (MARGIN_PX_SIZE * 2);
512513
}
513514

514-
private static int getWebViewMaxSizeY(Activity activity) {
515-
return OSViewUtils.getWindowHeight(activity) - (MARGIN_PX_SIZE * 2);
515+
private int getWebViewMaxSizeY(Activity activity) {
516+
int margin = messageContent.isFullScreen() ? 0 : (MARGIN_PX_SIZE * 2);
517+
return OSViewUtils.getWindowHeight(activity) - margin;
516518
}
517519

518520
private void removeActivityListener() {

0 commit comments

Comments
 (0)