Fix remove external id

* If remote params had the require_user_id_auth with true then the remove external id was not working due to requiring token hash
* Remove token hash check when removing external id

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

@@ -1593,7 +1593,7 @@ public void run() {
                return;
             }
 
-            if (externalId.length() > 0 && remoteParams != null && remoteParams.useUserIdAuth && (externalIdAuthHash == null || externalIdAuthHash.length() == 0)) {
+            if (!externalId.isEmpty() && externalId.length() > 0 && remoteParams != null && remoteParams.useUserIdAuth && (externalIdAuthHash == null || externalIdAuthHash.length() == 0)) {
                String errorMessage = "External Id authentication (auth token) is set to REQUIRED for this application. Please provide an auth token from your backend server or change the setting in the OneSignal dashboard.";
                Log(LOG_LEVEL.ERROR, errorMessage);
                return;

OneSignalSDK/unittest/src/test/java/com/test/onesignal/MainOneSignalClassRunner.java

@@ -4309,6 +4309,9 @@ public void shouldRemoveExternalUserIdFromPushWithAuthHash() throws Exception {
       OneSignalInit();
       threadAndTaskWait();
 
+      fastColdRestartApp();
+      OneSignalInit();
+      threadAndTaskWait();
       OneSignal.removeExternalUserId(getExternalUserIdUpdateCompletionHandler());
       threadAndTaskWait();
 
@@ -4321,9 +4324,9 @@ public void shouldRemoveExternalUserIdFromPushWithAuthHash() throws Exception {
       );
       assertEquals(expectedExternalUserIdResponse.toString(), lastExternalUserIdResponse.toString());
 
-      assertEquals(3, ShadowOneSignalRestClient.networkCallCount);
+      assertEquals(4, ShadowOneSignalRestClient.networkCallCount);
 
-      ShadowOneSignalRestClient.Request removeIdRequest = ShadowOneSignalRestClient.requests.get(2);
+      ShadowOneSignalRestClient.Request removeIdRequest = ShadowOneSignalRestClient.requests.get(3);
       assertEquals(ShadowOneSignalRestClient.REST_METHOD.PUT, removeIdRequest.method);
       assertEquals(removeIdRequest.payload.getString("external_user_id"), "");
       assertEquals(mockExternalIdHash, removeIdRequest.payload.getString("external_user_id_auth_hash"));