Skip to content

Commit 0e0bcde

Browse files
authored
Removed any closes on the SQL DBs, causing DB lock issues (#995)
* SQL DB was designed so that Java will simply garbage collect when it deems necessary to do so * No need to close the DB for within our SDK manually
1 parent fd21a6d commit 0e0bcde

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageRepository.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ synchronized void deleteOldRedisplayedInAppMessages() {
3434
writableDb.delete(OneSignalDbContract.InAppMessageTable.TABLE_NAME,
3535
OneSignalDbContract.InAppMessageTable.COLUMN_NAME_LAST_DISPLAY + "< ?",
3636
new String[]{String.valueOf(sixMonthsAgo)});
37-
writableDb.close();
3837
}
3938

4039
@WorkerThread
@@ -52,7 +51,6 @@ synchronized void saveInAppMessage(OSInAppMessage inAppMessage) {
5251
OneSignalDbContract.InAppMessageTable.COLUMN_NAME_MESSAGE_ID + " = ?", new String[]{inAppMessage.messageId});
5352
if (rowsUpdated == 0)
5453
writableDb.insert(OneSignalDbContract.InAppMessageTable.TABLE_NAME, null, values);
55-
writableDb.close();
5654
}
5755

5856
@WorkerThread

OneSignalSDK/onesignal/src/main/java/com/onesignal/OutcomeEventsCache.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ synchronized static void saveOutcomeEvent(OutcomeEvent event, OneSignalDbHelper
6060
values.put(OutcomeEventsTable.COLUMN_NAME_WEIGHT, event.getWeight());
6161

6262
writableDb.insert(OutcomeEventsTable.TABLE_NAME, null, values);
63-
writableDb.close();
6463
}
6564

6665
/**
@@ -133,8 +132,6 @@ synchronized static void saveUniqueOutcomeNotifications(JSONArray notificationId
133132
} catch (JSONException e) {
134133
e.printStackTrace();
135134
}
136-
137-
writableDb.close();
138135
}
139136

140137
/**

0 commit comments

Comments
 (0)