Skip to content

Commit 034618a

Browse files
authored
Merge pull request #1411 from OneSignal/compat/android12/add_pending_intent_flag_immutable
Android 12 Compatibility -add pending intent flag immutable
2 parents 5f48f07 + 0192817 commit 034618a

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ private static CharSequence getTitle(JSONObject fcmJson) {
128128
}
129129

130130
private static PendingIntent getNewDismissActionPendingIntent(int requestCode, Intent intent) {
131-
return PendingIntent.getBroadcast(currentContext, requestCode, intent, PendingIntent.FLAG_UPDATE_CURRENT);
131+
return PendingIntent.getBroadcast(currentContext, requestCode, intent, PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_IMMUTABLE);
132132
}
133133

134134
private static Intent getNewBaseDismissIntent(int notificationId) {

OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotificationOpenIntent.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ class GenerateNotificationOpenIntent(
5959
requestCode: Int,
6060
oneSignalIntent: Intent,
6161
): PendingIntent? {
62+
val flags = PendingIntent.FLAG_UPDATE_CURRENT or PendingIntent.FLAG_IMMUTABLE
6263
val launchIntent = getIntentVisible()
6364
?:
6465
// Even though the default app open action is disabled we still need to attach OneSignal's
@@ -71,7 +72,7 @@ class GenerateNotificationOpenIntent(
7172
context,
7273
requestCode,
7374
oneSignalIntent,
74-
PendingIntent.FLAG_UPDATE_CURRENT
75+
flags
7576
)
7677

7778

@@ -84,7 +85,7 @@ class GenerateNotificationOpenIntent(
8485
context,
8586
requestCode,
8687
arrayOf(launchIntent, oneSignalIntent),
87-
PendingIntent.FLAG_UPDATE_CURRENT
88+
flags
8889
)
8990
}
9091

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSBackgroundSync.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ private PendingIntent syncServicePendingIntent(Context context) {
178178
context,
179179
getSyncTaskId(),
180180
new Intent(context, getSyncServicePendingIntentClass()),
181-
PendingIntent.FLAG_UPDATE_CURRENT
181+
PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_IMMUTABLE
182182
);
183183
}
184184

0 commit comments

Comments
 (0)