Unit test for page changed event

Author: emawby

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageController.java

@@ -281,8 +281,8 @@ void onFailure(int statusCode, String response, Throwable throwable) {
         }
     }
 
-    void onPageChanged(@NonNull final OSInAppMessage message, @NonNull final JSONObject messageJson) {
-        final OSInAppMessagePage newPage = new OSInAppMessagePage(messageJson);
+    void onPageChanged(@NonNull final OSInAppMessage message, @NonNull final JSONObject eventJson) {
+        final OSInAppMessagePage newPage = new OSInAppMessagePage(eventJson);
         if (message.isPreview) {
             return;
         }

OneSignalSDK/unittest/src/test/java/com/onesignal/InAppMessagingHelpers.java

@@ -17,6 +17,7 @@ public class InAppMessagingHelpers {
     public static final String TEST_ENGLISH_ANDROID_VARIANT_ID = "11e4-bed1-df8f05be55ba-a4b3gj7f-d8cc";
     public static final String ONESIGNAL_APP_ID = "b4f7f966-d8cc-11e4-bed1-df8f05be55ba";
     public static final String IAM_CLICK_ID = "12345678-1234-1234-1234-123456789012";
+    public static final String IAM_PAGE_ID = "12345678-1234-ABCD-1234-123456789012";
 
     public static boolean evaluateMessage(OSInAppMessage message) {
         return OneSignal.getInAppMessageController().triggerController.evaluateMessageTriggers(message);
@@ -160,9 +161,17 @@ public static JSONObject buildTestActionJson() throws JSONException {
             put("url", "https://www.onesignal.com");
             put("url_target", "webview");
             put("close", true);
+            put("page_id", IAM_PAGE_ID);
             put("data", new JSONObject() {{
                 put("test", "value");
             }});
         }};
     }
+
+    public static JSONObject buildTestPageJson() throws JSONException {
+        return new JSONObject() {{
+            put("page_index", 1);
+            put("page_id", IAM_PAGE_ID);
+        }};
+    }
 }

OneSignalSDK/unittest/src/test/java/com/onesignal/OneSignalPackagePrivateHelper.java

@@ -495,6 +495,10 @@ public static void onMessageWasShown(@NonNull com.onesignal.OSInAppMessage messa
       OneSignal.getInAppMessageController().onMessageWasShown(message);
    }
 
+   public static void onPageChanged(@NonNull com.onesignal.OSInAppMessage message, @NonNull final JSONObject eventJson) {
+      OneSignal.getInAppMessageController().onPageChanged(message, eventJson);
+   }
+
    public static List<OSTestInAppMessage> getRedisplayInAppMessages() {
       List<OSInAppMessage> messages = OneSignal.getInAppMessageController().getRedisplayedInAppMessages();
       List<OSTestInAppMessage> testMessages = new ArrayList<>();

OneSignalSDK/unittest/src/test/java/com/test/onesignal/InAppMessagingUnitTests.java

@@ -616,4 +616,19 @@ public void testOnMessageWasShown() throws Exception {
         assertEquals(1, iamImpressionRequest.payload.get("device_type"));
         assertEquals(true, iamImpressionRequest.payload.get("first_impression"));
     }
+
+    @Test
+    public void testOnPageChanged() throws Exception {
+        threadAndTaskWait();
+
+        OneSignalPackagePrivateHelper.onPageChanged(message, InAppMessagingHelpers.buildTestPageJson());
+
+        ShadowOneSignalRestClient.Request iamPageImpressionRequest = ShadowOneSignalRestClient.requests.get(2);
+
+        assertEquals("in_app_messages/" + message.messageId + "/pageImpression", iamPageImpressionRequest.url);
+        assertEquals(InAppMessagingHelpers.ONESIGNAL_APP_ID, iamPageImpressionRequest.payload.get("app_id"));
+        assertEquals(ShadowOneSignalRestClient.pushUserId, iamPageImpressionRequest.payload.get("player_id"));
+        assertEquals(1, iamPageImpressionRequest.payload.get("device_type"));
+        assertEquals(InAppMessagingHelpers.IAM_PAGE_ID, iamPageImpressionRequest.payload.get("page_id"));
+    }
 }