Skip to content

I think there might be some problem in your padding_same_conv.py #1

@Gasoonjia

Description

@Gasoonjia

Your padding_same_conv.py is a brilliant implementation for pytorch users needing padding=same. It really helps me and I cannot express anything but gratitude for your wonderful work.

However, I think there might be some mistakes in your implementation, especially in your conv2d_same_padding function.
You only calculate the number of elements padded for the col of the input, and just copy it to the row, which might be wrong when stride[0] != stride [1] and dilation[0] != dilation[1].
And the type of your initial value of stride and dilation might be list according to your following code but not the int you set.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions